Rubocop?

[mroderick]

There is a Rubocop configuration in the repository

• It is not used in CI
• There are currently errors in the codebase

Shall we re-vitalise the use of Rubocop in this app?

If yes, then I suggest the following order of activities

1. Have @olleolleolle look over the current configuration, addressing only things that are very outdated
2. We fix the existing errors under the existing configuration
3. We enable Rubocop in CI
4. We gradually improve the configuration and codebase with smaller, targeted pull requests

[olleolleolle]

This change would stop the warnings at startup of the tool:

diff --git a/.rubocop.yml b/.rubocop.yml
index b33751a4..d5b3bf2c 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -9,11 +9,10 @@ AllCops:
     - bin/**/*
     - vendor/bundle/**/*

-require:
-  - rubocop
+plugins:
+  - rubocop-performance
   - rubocop-rails
   - rubocop-rspec
-  - rubocop-performance

 Layout/LineLength:
   Max: 120

[olleolleolle]

It made me think further. EDIT: #2325

I will add a configuration file for haml-lint as well. (Done, above PR.)

Example output from one of its linters:

olle.jonsson@Olles-Laptop planner % bundle exec haml-lint -i ClassAttributeWithStaticValue app/views
app/views/event_invitation_mailer/attending.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/event_invitation_mailer/attending.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/event_invitation_mailer/invite_coach.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/event_invitation_mailer/invite_coach.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/event_invitation_mailer/invite_student.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/event_invitation_mailer/invite_student.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/feedback_request_mailer/request_feedback.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/feedback_request_mailer/request_feedback.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/approve_from_waitlist.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/approve_from_waitlist.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/attendance_reminder.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/attendance_reminder.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/attending.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/attending.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/invite.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/meeting_invitation_mailer/invite.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/shared_mailers/_social.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/attending.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/attending.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/attending_reminder.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/attending_reminder.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/invite_coach.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/invite_coach.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/invite_student.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/invite_student.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/waiting_list_reminder.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/virtual_workshop_invitation_mailer/waiting_list_reminder.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/attending.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/attending.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/attending_reminder.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/attending_reminder.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/invite_coach.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/invite_coach.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/invite_student.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/invite_student.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/notify_waiting_list.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/notify_waiting_list.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/waiting_list_reminder.html.haml:6 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names
app/views/workshop_invitation_mailer/waiting_list_reminder.html.haml:9 [W] ClassAttributeWithStaticValue: Avoid defining `class` in attributes hash for static class names

173 files inspected, 39 lints detected