Fixed pmd wanrings.

Author: fpapadopou

Symfony/src/Codebender/ApiBundle/Controller/DefaultController.php

@@ -133,7 +133,7 @@ protected function checkHeaders($files,  array $personalLibs)
                     foreach ($data['files'] as $file) {
                         $foundFiles[] = $file['filename'];
                     }
-                } else {
+                } elseif (!$data['success']){
                     $notFoundHeaders[] = $header . ".h";
                 }
             }

Symfony/src/Codebender/ApiBundle/DependencyInjection/CodebenderApiExtension.php

@@ -20,7 +20,7 @@ class CodebenderApiExtension extends Extension
     public function load(array $configs, ContainerBuilder $container)
     {
         $configuration = new Configuration();
-        $config = $this->processConfiguration($configuration, $configs);
+        $this->processConfiguration($configuration, $configs);
 
         $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services.yml');

Symfony/src/Codebender/ApiBundle/DependencyInjection/Configuration.php

@@ -18,7 +18,7 @@ class Configuration implements ConfigurationInterface
     public function getConfigTreeBuilder()
     {
         $treeBuilder = new TreeBuilder();
-        $rootNode = $treeBuilder->root('codebender_api');
+        $treeBuilder->root('codebender_api');
 
         // Here you should define the parameters that are allowed to
         // configure your bundle. See the documentation linked above for

Symfony/src/Codebender/ApiBundle/Handler/DefaultHandler.php

@@ -6,48 +6,48 @@ class DefaultHandler
 {
     public function get_data($url, $var, $value)
     {
-        $ch = curl_init();
+        $curlHandle = curl_init();
         $timeout = 10;
-        curl_setopt($ch,CURLOPT_URL,$url);
-        curl_setopt($ch,CURLOPT_RETURNTRANSFER,1);
-        curl_setopt($ch,CURLOPT_CONNECTTIMEOUT,$timeout);
+        curl_setopt($curlHandle,CURLOPT_URL,$url);
+        curl_setopt($curlHandle,CURLOPT_RETURNTRANSFER,1);
+        curl_setopt($curlHandle,CURLOPT_CONNECTTIMEOUT,$timeout);
 
-        curl_setopt($ch,CURLOPT_POST,1);
-        curl_setopt($ch,CURLOPT_POSTFIELDS,$var.'='.$value);
+        curl_setopt($curlHandle,CURLOPT_POST,1);
+        curl_setopt($curlHandle,CURLOPT_POSTFIELDS,$var.'='.$value);
 
-        $data = curl_exec($ch);
-        curl_close($ch);
+        $data = curl_exec($curlHandle);
+        curl_close($curlHandle);
         return $data;
     }
 
     public function post_raw_data($url, $raw_data)
     {
-        $ch = curl_init();
+        $curlHandle = curl_init();
         $timeout = 10;
-        curl_setopt($ch, CURLOPT_URL,$url);
-        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
-        curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, $timeout);
+        curl_setopt($curlHandle, CURLOPT_URL,$url);
+        curl_setopt($curlHandle, CURLOPT_RETURNTRANSFER, 1);
+        curl_setopt($curlHandle, CURLOPT_CONNECTTIMEOUT, $timeout);
 
-        curl_setopt($ch, CURLOPT_POST, 1);
-        curl_setopt($ch, CURLOPT_POSTFIELDS, $raw_data);
-        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
+        curl_setopt($curlHandle, CURLOPT_POST, 1);
+        curl_setopt($curlHandle, CURLOPT_POSTFIELDS, $raw_data);
+        curl_setopt($curlHandle, CURLOPT_SSL_VERIFYPEER, false);
 
-        $data = curl_exec($ch);
+        $data = curl_exec($curlHandle);
 
-        curl_close($ch);
+        curl_close($curlHandle);
         return $data;
     }
 
     public function get($url)
     {
-        $ch = curl_init();
+        $curlHandle = curl_init();
         $timeout = 10;
-        curl_setopt($ch,CURLOPT_URL,$url);
-        curl_setopt($ch,CURLOPT_RETURNTRANSFER,1);
-        curl_setopt($ch,CURLOPT_CONNECTTIMEOUT,$timeout);
+        curl_setopt($curlHandle,CURLOPT_URL,$url);
+        curl_setopt($curlHandle,CURLOPT_RETURNTRANSFER,1);
+        curl_setopt($curlHandle,CURLOPT_CONNECTTIMEOUT,$timeout);
 
-        $data = curl_exec($ch);
-        curl_close($ch);
+        $data = curl_exec($curlHandle);
+        curl_close($curlHandle);
         return $data;
     }