Skip to content

Commit 0780c4a

Browse files
committed
Added comment support for examples that do not compile with any available board.
1 parent f068554 commit 0780c4a

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

codebender_testing/disqus.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,16 +101,21 @@ def handle_example_comment(self, url, results, current_date, log):
101101
post_id, existing_message = self.get_posts(page['id'])
102102
if post_id and existing_message:
103103
boards = []
104+
unsupportedFlag = False
104105
for result in results:
105106
if result['status'] == 'success':
106107
board = result['board']
107108
if re.match(r'Arduino Mega.+', board):
108109
board = 'Arduino Mega'
109110
boards.append(board)
111+
elif result['status'] == 'unsupported':
112+
unsupportedFlag = True
110113

111114
new_message = self.messages['example_fail'].replace('TEST_DATE', current_date)
112115
if len(boards) > 0:
113116
new_message = self.messages['example_success'].replace('TEST_DATE', current_date).replace('BOARDS_LIST', ', '.join(boards))
117+
elif unsupportedFlag:
118+
new_message = self.messages['example_unsupported']
114119
log[url]['comment'] = self.update_post(post_id, new_message)
115120
break
116121
else:

codebender_testing/utils.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,8 +444,15 @@ def compile_sketches(self, sketches, iframe=False, logfile=None, compile_type='s
444444
if url_fragments.path in BOARDS_DB['special_boards']:
445445
boards = BOARDS_DB['special_boards'][url_fragments.path]
446446

447-
# Run Verify
448-
results = self.compile_sketch(sketch, boards, iframe=iframe)
447+
if len(boards) > 0:
448+
# Run Verify
449+
results = self.compile_sketch(sketch, boards, iframe=iframe)
450+
else:
451+
results = [
452+
{
453+
'status': 'unsupported'
454+
}
455+
]
449456

450457
# Used when not funning in Full mode
451458
if logfile is None or not self.run_full_compile_tests:
@@ -473,6 +480,8 @@ def compile_sketches(self, sketches, iframe=False, logfile=None, compile_type='s
473480
'board': result['board'],
474481
'error': result['message']
475482
})
483+
elif result['status'] == 'unsupported':
484+
log_entry[sketch]['unsupported'] = True
476485

477486
# Update Disqus comments
478487
if compile_type == 'library' and comment:

0 commit comments

Comments
 (0)