Simplified logic in commenting of libraries when compiling examples.

Author: freskoulix

codebender_testing/disqus.py

@@ -57,29 +57,29 @@ def get_disqus_sso(self, user):
         sig = hmac.HMAC(self.DISQUS_API_SECRET, '%s %s' % (message, timestamp), hashlib.sha1).hexdigest()
         return "{0} {1} {2}".format(message, sig, timestamp)
 
-    def update_comment(self, sketch, results, current_date, log_entry, openFailFlag, counter, total_sketches):
-        # Comment examples
-        if not openFailFlag:
-            log_entry = self.handle_example_comment(sketch, results, current_date, log_entry)
-
-        # Comment libraries when finished commenting the examples
+    def update_comment(self, sketch, results, current_date, log_entry, openFailFlag, total_sketches):
+        # Comment libraries
         library_match = re.match(r'.+\/example\/(.+)\/.+', sketch)
         library = None
+        library_to_comment = None
         if library_match:
             library = library_match.group(1)
         if not self.last_library:
             self.last_library = library
+            library_to_comment = library
 
-        library_to_comment = None
-        if self.last_library and self.last_library not in self.examples_without_library and library != self.last_library:
-            library_to_comment = self.last_library
-        if library and library not in self.examples_without_library and counter >= total_sketches-1:
+        if library != self.last_library:
             library_to_comment = library
+
         if library_to_comment:
             log_entry = self.handle_library_comment(library_to_comment, current_date, log_entry)
 
         self.last_library = library
 
+        # Comment examples
+        if not openFailFlag:
+            log_entry = self.handle_example_comment(sketch, results, current_date, log_entry)
+
         return log_entry
 
     def handle_library_comment(self, library, current_date, log):

codebender_testing/utils.py

@@ -575,7 +575,7 @@ def compile_sketches(self, sketches, iframe=False, project_view=False, logfile=N
         total_sketches = len(urls_to_visit)
         tic = time.time()
 
-        for counter, sketch in enumerate(urls_to_visit):
+        for sketch in urls_to_visit:
             # Read the boards map in case current sketch/example requires a special board configuration
             boards = BOARDS_DB['default_boards']
             url_fragments = urlparse(sketch)
@@ -629,7 +629,7 @@ def compile_sketches(self, sketches, iframe=False, project_view=False, logfile=N
 
             # Update Disqus comments
             if compile_type in ['library', 'target_library'] and comment:
-                log_entry = disqus_wrapper.update_comment(sketch, results, current_date, log_entry, openFailFlag, counter, total_sketches)
+                log_entry = disqus_wrapper.update_comment(sketch, results, current_date, log_entry, openFailFlag, total_sketches)
 
             # Dump the test results to `logfile`.
             with open(log_file, 'w') as f: