Skip to content

Commit 2458222

Browse files
committed
Cleaned up un-needed code.
1 parent 9f64a3c commit 2458222

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

codebender_testing/disqus.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def update_comment(self, sketch, results, current_date, log_entry, openFailFlag,
7070
self.last_library = library
7171
if library and library != self.last_library and (library not in self.examples_without_library or counter >= total_sketches-1):
7272
log_entry = self.handle_library_comment(library, current_date, log_entry)
73-
last_library = library
73+
self.last_library = library
7474

7575
return log_entry
7676

@@ -121,7 +121,6 @@ def handle_example_comment(self, url, results, current_date, log):
121121
return log
122122

123123
def get_posts(self, thread_id):
124-
post_found = False
125124
post_id = None
126125
raw_message = None
127126
paginator = disqusapi.Paginator(self.disqus.api.posts.list, forum=FORUM, thread=thread_id, order='asc', method='GET')

codebender_testing/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ def create_sketch(self, name):
529529

530530
def check_iframe(self):
531531
"""Returns the contents of an iframe [project_name, user_name, sketch_contents]"""
532-
self.driver.switch_to_frame(driver.find_element_by_tag_name('iframe'))
532+
self.driver.switch_to_frame(self.driver.find_element_by_tag_name('iframe'))
533533
project_name = self.driver.find_element_by_class_name('projectName').text
534534
user_name = self.driver.find_element_by_class_name('userName').text
535535
sketch_contents = self.execute_script('return editor.aceEditor.getValue();', 'editor')
@@ -637,7 +637,7 @@ def test_serial_monitor(self, selector):
637637

638638
def check_element_exists(self, css_path):
639639
try:
640-
element = self.driver.find_element_by_css_selector(css_path)
640+
self.driver.find_element_by_css_selector(css_path)
641641
return True
642642
except NoSuchElementException:
643643
return False

tests/common/embedded_views/test_embedded.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,9 @@ class TestHome(CodebenderEmbeddedTestCase):
2020

2121
def test_embedded_views(self):
2222
embed_sketch_re = re.compile('^https:\/\/codebender\.cc\/embed\/sketch:\d+$')
23-
example_re = re.compile('^https:\/\/codebender\.cc\/example\/.+$$')
24-
serial_monitor_re = re.compile('^https:\/\/codebender\.cc\/embed\/serialmonitor$$')
2523
for embedded in EMBEDDED_VIEWS:
2624
self.open(embedded)
2725
iframes = self.driver.find_elements_by_tag_name('iframe')
28-
test_iframes = []
2926
for iframe in iframes:
3027
iframe_src = iframe.get_attribute('src')
3128
if embed_sketch_re.match(iframe_src):

0 commit comments

Comments
 (0)