Add test for ports dropdown and flashing

Note: these tests currently fail, as Selenium is not (yet) playing
well with browser extensions.

Author: Brandon Duffany

codebender_testing/config.py

@@ -17,3 +17,5 @@
 
 TEST_PROJECT_NAME = "test_project"
 
+# How long we wait until giving up on trying to locate an element
+ELEMENT_FIND_TIMEOUT = 5

codebender_testing/utils.py

@@ -3,15 +3,17 @@
 from selenium import webdriver
 from selenium.common.exceptions import NoSuchElementException
 from selenium.webdriver.common.keys import Keys
+from selenium.webdriver.support import expected_conditions
+from selenium.webdriver.support.ui import WebDriverWait
 import pytest
 
 from codebender_testing.config import BASE_URL
+from codebender_testing.config import ELEMENT_FIND_TIMEOUT
 from codebender_testing.config import TEST_CREDENTIALS
 from codebender_testing.config import TEST_PROJECT_NAME
 from codebender_testing.config import WEBDRIVERS
 
 
-
 class SeleniumTestCase(object):
     """Base class for all Selenium tests."""
 
@@ -71,3 +73,10 @@ def login(self):
             # 'Log In' is not displayed, so we're already logged in.
             pass
 
+    def get_element(self, *locator):
+        """Waits for an element specified by *locator (a tuple of
+        (By.<something>, str)), then returns it if it is found."""
+        WebDriverWait(self.driver, ELEMENT_FIND_TIMEOUT).until(
+            expected_conditions.presence_of_element_located(locator))
+        return self.driver.find_element(*locator)
+        

tests/sketch/test_sketch.py

@@ -11,11 +11,9 @@
 from codebender_testing.utils import SeleniumTestCase
 
 
-# How long to wait before we give up on the 'verify' command (in seconds)
+# How long to wait before we give up on trying to assess the result of commands
 VERIFY_TIMEOUT = 10
-
-# How long to wait before we give up on finding an element on the page.
-ELEMENT_FIND_TIMEOUT = 5
+FLASH_TIMEOUT = 2
 
 # Board to test for the dropdown selector.
 TEST_BOARD = "Arduino Fio"
@@ -32,7 +30,7 @@ def open_test_project(self, tester_login):
         # I get a StaleElementReferenceException without
         # this wait. TODO: figure out how to get around this.
         time.sleep(3)
-    
+ 
     def test_verify_code(self):
         """Ensures that we can compile code and see the success message."""
         compile_button = self.driver.find_element_by_id("compile")
@@ -46,15 +44,22 @@ def test_verify_code(self):
     def test_boards_dropdown(self):
         """Tests that the boards dropdown is present, and that we can change
         the board successfully."""
-        WebDriverWait(self.driver, ELEMENT_FIND_TIMEOUT).until(
-            expected_conditions.presence_of_element_located(
-            (By.ID, "boards"))
-        )
-
-        boards_dropdown = Select(self.driver.find_element_by_id("boards"))
+        boards_dropdown = Select(self.get_element(By.ID, "boards"))
 
         # Click something other than the first option
         boards_dropdown.select_by_visible_text(TEST_BOARD)
 
         assert boards_dropdown.first_selected_option.text == TEST_BOARD
 
+    def test_ports_dropdown(self):
+        """Ensures that the ports dropdown exists."""
+        self.get_element(By.ID, "ports")
+
+    def test_run_with_no_port(self):
+        """Makes sure that there is an error when we attempt to run with no
+        port selected."""
+        flash_button = self.get_element(By.ID, "usbflash")
+        flash_button.click()
+        WebDriverWait(self.driver, FLASH_TIMEOUT).until(
+            expected_condiditons.text_to_be_present_in_element(
+                (By.ID, "operation_output"), "Please select a valid port or enable the plugin!!"))