Fix flaky test_home.py

Author: Brandon Duffany

codebender_testing/config.py

@@ -38,8 +38,8 @@ def _rel_path(*args):
 # Directory in which the local compile tester files are stored.
 COMPILE_TESTER_DIR = os.path.join(TEST_DATA_DIR, 'cb_compile_tester')
 
-# Set up Selenium Webdrivers to be used for selenium tests
 
+# Set up Selenium Webdrivers to be used for selenium tests
 def _get_firefox_profile():
     """Returns the Firefox profile to be used for the FF webdriver.
     Specifically, we're equipping the webdriver with the Codebender
@@ -59,7 +59,7 @@ def _get_firefox_profile():
 # module is imported (hence the need for lazy evaluation).
 WEBDRIVERS = {
     "firefox": lambda: webdriver.Firefox(firefox_profile=_get_firefox_profile()),
-#   "chrome": lambda: webdriver.Chrome()
+    # "chrome": lambda: webdriver.Chrome()
 }
 
 # Credentials to use when logging into the site via selenium

codebender_testing/utils.py

@@ -203,6 +203,15 @@ def login(self):
             # 'Log In' is not displayed, so we're already logged in.
             pass
 
+    def logout(self):
+        """Logs out of the site."""
+        try:
+            logout_button = self.driver.find_element_by_id("logout")
+            logout_button.send_keys(Keys.ENTER)
+        except NoSuchElementException:
+            # 'Log out' is not displayed, so we're already logged out.
+            pass
+
     def get_element(self, *locator):
         """Waits for an element specified by *locator (a tuple of
         (By.<something>, str)), then returns it if it is found."""
@@ -217,11 +226,11 @@ def get_elements(self, *locator):
             expected_conditions.visibility_of_all_elements_located_by(locator))
         return self.driver.find_elements(*locator)
 
-    def get(self, selector):
+    def find(self, selector):
         """Alias for `self.get_element(By.CSS_SELECTOR, selector)`."""
         return self.get_element(By.CSS_SELECTOR, selector)
 
-    def get_all(self, selector):
+    def find_all(self, selector):
         """Alias for `self.get_elements(By.CSS_SELECTOR, selector)`."""
         return self.get_elements(By.CSS_SELECTOR, selector)
 
@@ -340,6 +349,10 @@ def _testcase_attrs(cls, webdriver, testing_url, testing_full):
     def tester_login(self):
         self.login()
 
+    @pytest.fixture(scope="class")
+    def tester_logout(self):
+        self.logout()
+
 
 class VerificationError(Exception):
     """An exception representing a failed verification of a sketch."""

tests/home/test_home.py

@@ -4,49 +4,49 @@
 
 class TestHome(SeleniumTestCase):
 
-    def test_navigate_home(self):
+    def test_navigate_home(self, tester_logout):
         """ opens browser to codebender bachelor """
         self.open("/")
         assert "Codebender" in self.driver.title
 
-    def test_login(self):
+    def test_login(self, tester_logout):
         driver = self.driver
         self.open("/")
 
-        """ tests to ensure login div appears """        
+        """ tests to ensure login div appears """
         login_elem = driver.find_element_by_id("login_btn")    #finds login button
         login_elem.send_keys(Keys.RETURN)                      #clicks login button
         logbox_elem = driver.find_element_by_id("login_box")   #finds login div
         assert logbox_elem.is_displayed()                      #checks to see if div is visible
 
         """ tests login with invalid username """
-        # define elements in login form 
+        # define elements in login form
         username_elem = driver.find_element_by_id("username")
         password_elem = driver.find_element_by_id("password")
         submit_elem = driver.find_element_by_id("_submit")
-        
+
         # enter invalid username with correct password
         username_elem.send_keys("codebender")
         password_elem.send_keys(TEST_CREDENTIALS['password'])
         submit_elem.click()
 
         # check for error message
         error_elem = driver.find_element_by_class_name('text-error')
-        assert error_elem.is_displayed() 
+        assert error_elem.is_displayed()
 
         """ tests login with invalid password """
         # refresh page so error message no longer visible
         driver.refresh()
 
         # re-click on login button
         login_elem = driver.find_element_by_id("login_btn")
-        login_elem.send_keys(Keys.RETURN) 
- 
-        # re-define elements in login form 
+        login_elem.send_keys(Keys.RETURN)
+
+        # re-define elements in login form
         username_elem = driver.find_element_by_id("username")
         password_elem = driver.find_element_by_id("password")
         submit_elem = driver.find_element_by_id("_submit")
-         
+
         # enter correct username with invalid password
         username_elem.clear()
         username_elem.send_keys(TEST_CREDENTIALS['username'])
@@ -63,9 +63,9 @@ def test_login(self):
 
         # re-click on login button
         login_elem = driver.find_element_by_id("login_btn")
-        login_elem.send_keys(Keys.RETURN) 
- 
-        # re-define elements in login form 
+        login_elem.send_keys(Keys.RETURN)
+
+        # re-define elements in login form
         username_elem = driver.find_element_by_id("username")
         password_elem = driver.find_element_by_id("password")
         submit_elem = driver.find_element_by_id("_submit")
@@ -77,18 +77,3 @@ def test_login(self):
         submit_elem.click()
         assert "Logged in as" in driver.page_source
 
-    def test_quit(self):
-        """ closes driver """
-        driver = self.driver
-        #driver.quit()
-
-
-
-
-
-
-
-
-
-
-