[cmd/mdatagen] add func to configure attribute set

Adding the ability to automatically add attributes via an attribute set when
recording telemetry through the TelemetryBuilder for internal metrics. This wraps
the otel go SDK functions for convenience. I have a follow up PR that demonstrates
how to use this, we *could* hide the otel go metrics directly, but that can be
done in a follow up PR if it's useful.

Signed-off-by: alex boten <[email protected]>

Author: codeboten

cmd/mdatagen/internal/command.go

@@ -316,6 +316,15 @@ func templatize(tmplFile string, md Metadata) *template.Template {
 				"isCommand": func() bool {
 					return md.Status.Class == "cmd"
 				},
+				"measurementFunc": func(s string) string {
+					switch s {
+					case "Int64Counter", "Float64Counter":
+						return "Add"
+					case "Int64Gauge", "Float64Gauge", "Int64Histogram", "Float64Histogram":
+						return "Record"
+					}
+					return "unsupported instrument"
+				},
 				"supportsLogs":             func() bool { return md.supportsSignal("logs") },
 				"supportsMetrics":          func() bool { return md.supportsSignal("metrics") },
 				"supportsTraces":           func() bool { return md.supportsSignal("traces") },

cmd/mdatagen/internal/samplereceiver/internal/metadata/generated_telemetry.go

@@ -14,6 +14,7 @@ import (
     "sync"
     {{- end }}
 
+    "go.opentelemetry.io/otel/attribute"
     "go.opentelemetry.io/otel/metric"
     {{- if .Telemetry.Metrics }}
         {{- range $_, $metric := .Telemetry.Metrics }}
@@ -40,6 +41,7 @@ func Tracer(settings component.TelemetrySettings) trace.Tracer {
 // TelemetryBuilder provides an interface for components to report telemetry
 // as defined in metadata and user config.
 type TelemetryBuilder struct {
+    attributeSet attribute.Set
     meter metric.Meter
 	mu sync.Mutex
     registrations []metric.Registration
@@ -61,6 +63,12 @@ func (tbof telemetryBuilderOptionFunc) apply(mb *TelemetryBuilder) {
   tbof(mb)
 }
 
+func WithAttributeSet(s attribute.Set) telemetryBuilderOptionFunc {
+    return func(mb *TelemetryBuilder){
+        mb.attributeSet = s
+    }
+}
+
 {{- range $name, $metric := .Telemetry.Metrics }}
     {{ if $metric.Data.Async -}}
 // Register{{ $name.Render }}Callback sets callback for observable {{ $name.Render }} metric.
@@ -76,6 +84,10 @@ func (builder *TelemetryBuilder) Register{{ $name.Render }}Callback(cb metric.{{
     defer builder.mu.Unlock()
     builder.registrations = append(builder.registrations, reg)
     return nil
+}
+    {{- else }}
+func (builder *TelemetryBuilder) Record{{ $name.Render }}DataPoint(ctx context.Context, val {{ $metric.Data.BasicType }}) {
+    builder.{{ $name.Render }}.{{ measurementFunc $metric.Data.Instrument }}(ctx, val, metric.WithAttributeSet(builder.attributeSet))
 }
     {{- end }}
 

cmd/mdatagen/internal/templates/telemetry.go.tmpl

@@ -6,19 +6,14 @@ package processorhelper // import "go.opentelemetry.io/collector/processor/proce
 import (
 	"context"
 
-	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/metric"
-
 	"go.opentelemetry.io/collector/pipeline"
 	"go.opentelemetry.io/collector/processor"
-	"go.opentelemetry.io/collector/processor/internal"
 	"go.opentelemetry.io/collector/processor/processorhelper/internal/metadata"
 )
 
 const signalKey = "otel.signal"
 
 type obsReport struct {
-	otelAttrs        metric.MeasurementOption
 	telemetryBuilder *metadata.TelemetryBuilder
 }
 
@@ -28,15 +23,11 @@ func newObsReport(set processor.Settings, signal pipeline.Signal) (*obsReport, e
 		return nil, err
 	}
 	return &obsReport{
-		otelAttrs: metric.WithAttributeSet(attribute.NewSet(
-			attribute.String(internal.ProcessorKey, set.ID.String()),
-			attribute.String(signalKey, signal.String()),
-		)),
 		telemetryBuilder: telemetryBuilder,
 	}, nil
 }
 
 func (or *obsReport) recordInOut(ctx context.Context, incoming, outgoing int) {
-	or.telemetryBuilder.ProcessorIncomingItems.Add(ctx, int64(incoming), or.otelAttrs)
-	or.telemetryBuilder.ProcessorOutgoingItems.Add(ctx, int64(outgoing), or.otelAttrs)
+	or.telemetryBuilder.RecordProcessorIncomingItemsDataPoint(ctx, int64(incoming))
+	or.telemetryBuilder.RecordProcessorOutgoingItemsDataPoint(ctx, int64(outgoing))
 }