Skip to content

Commit 6be942a

Browse files
committed
more changes needed
Signed-off-by: Alex Boten <[email protected]>
1 parent aca8726 commit 6be942a

File tree

7 files changed

+0
-24
lines changed

7 files changed

+0
-24
lines changed

.github/workflows/utils/cspell.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@
6565
"Rahul",
6666
"Reques",
6767
"SASL",
68-
"SPECPATH",
69-
"SPECTAG",
7068
"Samplingdecision",
7169
"Sharma",
7270
"Statefulness",
@@ -215,7 +213,6 @@
215213
"gcflags",
216214
"genpdata",
217215
"genproto",
218-
"gensemconv",
219216
"godoc",
220217
"gofmt",
221218
"golangci",
@@ -395,7 +392,6 @@
395392
"scraperhelper",
396393
"scrapertest",
397394
"semconv",
398-
"semconvgen",
399395
"servicetelemetry",
400396
"servicetest",
401397
"servicez",

Makefile

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -249,17 +249,6 @@ genpdata:
249249
pushd pdata/ && $(GOCMD) run ./internal/cmd/pdatagen/main.go && popd
250250
$(MAKE) fmt
251251

252-
# Generate semantic convention constants. Requires a clone of the opentelemetry-specification repo
253-
gensemconv: $(SEMCONVGEN) $(SEMCONVKIT)
254-
@[ "${SPECPATH}" ] || ( echo ">> env var SPECPATH is not set"; exit 1 )
255-
@[ "${SPECTAG}" ] || ( echo ">> env var SPECTAG is not set"; exit 1 )
256-
@echo "Generating semantic convention constants from specification version ${SPECTAG} at ${SPECPATH}"
257-
$(SEMCONVGEN) -o semconv/${SPECTAG} -t semconv/template.j2 -s ${SPECTAG} -i ${SPECPATH}/model/. --only=resource -p conventionType=resource -f generated_resource.go
258-
$(SEMCONVGEN) -o semconv/${SPECTAG} -t semconv/template.j2 -s ${SPECTAG} -i ${SPECPATH}/model/. --only=event -p conventionType=event -f generated_event.go
259-
$(SEMCONVGEN) -o semconv/${SPECTAG} -t semconv/template.j2 -s ${SPECTAG} -i ${SPECPATH}/model/. --only=span -p conventionType=trace -f generated_trace.go
260-
$(SEMCONVGEN) -o semconv/${SPECTAG} -t semconv/template.j2 -s ${SPECTAG} -i ${SPECPATH}/model/. --only=attribute_group -p conventionType=attribute_group -f generated_attribute_group.go
261-
$(SEMCONVKIT) -output "semconv/$(SPECTAG)" -tag "$(SPECTAG)"
262-
263252
ALL_MOD_PATHS := "" $(ALL_MODULES:.%=%)
264253

265254
.PHONY: prepare-contrib

Makefile.Common

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ IMPI := $(TOOLS_BIN_DIR)/impi
4040
MISSPELL := $(TOOLS_BIN_DIR)/misspell
4141
MULTIMOD := $(TOOLS_BIN_DIR)/multimod
4242
PORTO := $(TOOLS_BIN_DIR)/porto
43-
SEMCONVGEN := $(TOOLS_BIN_DIR)/semconvgen
44-
SEMCONVKIT := $(TOOLS_BIN_DIR)/semconvkit
4543
GOTESTSUM := $(TOOLS_BIN_DIR)/gotestsum
4644

4745
.PHONY: install-tools

internal/tools/go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ require (
1818
go.opentelemetry.io/build-tools/crosslink v0.23.1
1919
go.opentelemetry.io/build-tools/githubgen v0.23.1
2020
go.opentelemetry.io/build-tools/multimod v0.23.1
21-
go.opentelemetry.io/build-tools/semconvgen v0.23.1
2221
golang.org/x/exp v0.0.0-20240909161429-701f63a606c0
2322
golang.org/x/tools v0.33.0
2423
golang.org/x/vuln v1.1.4

internal/tools/go.sum

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/tools/tools.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,9 @@ import (
2424
_ "go.opentelemetry.io/build-tools/crosslink"
2525
_ "go.opentelemetry.io/build-tools/githubgen"
2626
_ "go.opentelemetry.io/build-tools/multimod"
27-
_ "go.opentelemetry.io/build-tools/semconvgen"
2827
_ "golang.org/x/exp/cmd/apidiff"
2928
_ "golang.org/x/tools/cmd/goimports"
3029
_ "golang.org/x/vuln/cmd/govulncheck"
3130
_ "gotest.tools/gotestsum"
3231
_ "mvdan.cc/gofumpt"
33-
34-
_ "go.opentelemetry.io/collector/internal/tools/semconvkit"
3532
)

versions.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ module-sets:
8888
- go.opentelemetry.io/collector/scraper
8989
- go.opentelemetry.io/collector/scraper/scraperhelper
9090
- go.opentelemetry.io/collector/scraper/scrapertest
91-
- go.opentelemetry.io/collector/semconv
9291
- go.opentelemetry.io/collector/service
9392
- go.opentelemetry.io/collector/service/hostcapabilities
9493
- go.opentelemetry.io/collector/filter

0 commit comments

Comments
 (0)