Skip to content

Commit c2e3c24

Browse files
Linda Pengangelocordon
authored andcommitted
Made some requested changes from @angelocordon
1 parent 7f26ea9 commit c2e3c24

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
<!--
22
For Work In Progress Pull Requests, please use the Draft PR feature,
33
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details.
4-
4+
55
Before submitting a Pull Request, please ensure you've done the following:
66
- 📖 Read the Contributing Guide: https://github.com/codebuddies/frontend/blob/main/CONTRIBUTING.md.
77
- 📖 Read the Open Sauced Code of Conduct: https://github.com/codebuddies/frontend/blob/main/CODE_OF_CONDUCT.MD.
8-
- 👷‍♀️ Aim to create small PRs by splitting up feature work, and potentially multiple issues.
8+
- 👷‍♀️ Aim to create small PRs by splitting up feature work, and potentially multiple issues.
99
- ✅ Provide tests for your changes if relevant.
1010
- 📝 Use descriptive commit messages.
1111
- 📗 Update any related documentation and include any relevant screenshots.
12-
Note: h/t to https://github.com/open-sauced/open-sauced/blob/main/.github/PULL_REQUEST_TEMPLATE.md for this pull request template model.
12+
Note: h/t to https://github.com/open-sauced/open-sauced/blob/main/.github/PULL_REQUEST_TEMPLATE.md for this pull request template model.
1313
-->
1414

1515
## What type of PR is this? (check all applicable)
@@ -24,24 +24,30 @@
2424

2525
## Context
2626

27+
Placeholder example: This PR closes issue #12
2728

2829
## Screenshots/Recordings (if there are UI changes)
2930

31+
Placeholder example: ![screenshot of new resource page](https://user-images.githubusercontent.com/4512699/89255710-3a3d4400-d5d7-11ea-9d56-8be1271d77a2.png)
3032

3133
## Implementation Details - what was your thought process as you changed the code?
3234

33-
35+
Placeholder example:
36+
[x] Made an axios GET request to /resources
37+
[x] Refactored to use useQuery library
38+
[x] Wrote tests
3439

3540
## Related Tickets & Documents (Optional)
3641

42+
Placeholder example: This relates to issue #23.
3743

44+
Filed issue #43 as a next step to do after this PR is merged.
3845

3946
## Added tests?
4047

4148
- [ ] 👍 yes
4249
- [ ] 🙅 no, because they aren't needed
4350
- [ ] 🙋 no, because I need help
44-
- [ ] ✨ other (e.g. I'll add more tests in a separate issue or PR)
4551

4652
## Added to documentation?
4753

0 commit comments

Comments
 (0)