|
1 | 1 | <!--
|
2 | 2 | For Work In Progress Pull Requests, please use the Draft PR feature,
|
3 | 3 | see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details.
|
4 |
| - |
| 4 | +
|
5 | 5 | Before submitting a Pull Request, please ensure you've done the following:
|
6 | 6 | - 📖 Read the Contributing Guide: https://github.com/codebuddies/frontend/blob/main/CONTRIBUTING.md.
|
7 | 7 | - 📖 Read the Open Sauced Code of Conduct: https://github.com/codebuddies/frontend/blob/main/CODE_OF_CONDUCT.MD.
|
8 |
| - - 👷♀️ Aim to create small PRs by splitting up feature work, and potentially multiple issues. |
| 8 | + - 👷♀️ Aim to create small PRs by splitting up feature work, and potentially multiple issues. |
9 | 9 | - ✅ Provide tests for your changes if relevant.
|
10 | 10 | - 📝 Use descriptive commit messages.
|
11 | 11 | - 📗 Update any related documentation and include any relevant screenshots.
|
12 |
| - Note: h/t to https://github.com/open-sauced/open-sauced/blob/main/.github/PULL_REQUEST_TEMPLATE.md for this pull request template model. |
| 12 | + Note: h/t to https://github.com/open-sauced/open-sauced/blob/main/.github/PULL_REQUEST_TEMPLATE.md for this pull request template model. |
13 | 13 | -->
|
14 | 14 |
|
15 | 15 | ## What type of PR is this? (check all applicable)
|
|
24 | 24 |
|
25 | 25 | ## Context
|
26 | 26 |
|
| 27 | +Placeholder example: This PR closes issue #12 |
27 | 28 |
|
28 | 29 | ## Screenshots/Recordings (if there are UI changes)
|
29 | 30 |
|
| 31 | +Placeholder example:  |
30 | 32 |
|
31 | 33 | ## Implementation Details - what was your thought process as you changed the code?
|
32 | 34 |
|
33 |
| - |
| 35 | +Placeholder example: |
| 36 | +[x] Made an axios GET request to /resources |
| 37 | +[x] Refactored to use useQuery library |
| 38 | +[x] Wrote tests |
34 | 39 |
|
35 | 40 | ## Related Tickets & Documents (Optional)
|
36 | 41 |
|
| 42 | +Placeholder example: This relates to issue #23. |
37 | 43 |
|
| 44 | +Filed issue #43 as a next step to do after this PR is merged. |
38 | 45 |
|
39 | 46 | ## Added tests?
|
40 | 47 |
|
41 | 48 | - [ ] 👍 yes
|
42 | 49 | - [ ] 🙅 no, because they aren't needed
|
43 | 50 | - [ ] 🙋 no, because I need help
|
44 |
| -- [ ] ✨ other (e.g. I'll add more tests in a separate issue or PR) |
45 | 51 |
|
46 | 52 | ## Added to documentation?
|
47 | 53 |
|
|
0 commit comments