Skip to content

Commit 842b4c3

Browse files
Claudeclaude
andcommitted
ci(ios): remove fastlane, fix App Store validation warnings
- Remove fastlane upload step; xcodebuild with destination=upload handles the upload to App Store Connect directly - Add LSSupportsOpeningDocumentsInPlace to Info.plist (required since CFBundleDocumentTypes is declared for Flipper NFC files) - Add ITSAppUsesNonExemptEncryption=NO to skip encryption compliance question on each upload Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 5e66202 commit 842b4c3

File tree

2 files changed

+5
-31
lines changed

2 files changed

+5
-31
lines changed

.github/workflows/ios-release.yml

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
DEVELOPMENT_TEAM=ZJ9GEQ36AH \
109109
PROVISIONING_PROFILE_SPECIFIER="$PROVISIONING_PROFILE_UUID"
110110
111-
- name: Export IPA
111+
- name: Export & upload to App Store Connect
112112
env:
113113
APP_STORE_CONNECT_API_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }}
114114
APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
@@ -148,36 +148,6 @@ jobs:
148148
-authenticationKeyID "$APP_STORE_CONNECT_API_KEY_ID" \
149149
-authenticationKeyIssuerID "$APP_STORE_CONNECT_ISSUER_ID"
150150
151-
- name: Install fastlane
152-
run: brew install fastlane
153-
154-
- name: Upload to TestFlight & distribute to internal testers
155-
env:
156-
APP_STORE_CONNECT_API_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }}
157-
APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
158-
run: |
159-
# Build the API key JSON that fastlane expects
160-
API_KEY_JSON="$RUNNER_TEMP/api_key.json"
161-
P8_CONTENTS=$(cat ~/.private_keys/AuthKey_"$APP_STORE_CONNECT_API_KEY_ID".p8)
162-
jq -n \
163-
--arg key_id "$APP_STORE_CONNECT_API_KEY_ID" \
164-
--arg issuer_id "$APP_STORE_CONNECT_ISSUER_ID" \
165-
--arg key "$P8_CONTENTS" \
166-
'{key_id: $key_id, issuer_id: $issuer_id, key: $key, in_house: false}' \
167-
> "$API_KEY_JSON"
168-
169-
# Find the IPA (xcodebuild may name it differently)
170-
IPA_PATH=$(find "$RUNNER_TEMP/export" -name '*.ipa' -print -quit)
171-
echo "IPA: $IPA_PATH"
172-
[ -f "$IPA_PATH" ] || { echo "No IPA found in $RUNNER_TEMP/export"; ls -la "$RUNNER_TEMP/export"; exit 1; }
173-
174-
fastlane pilot upload \
175-
--ipa "$IPA_PATH" \
176-
--api_key_path "$API_KEY_JSON" \
177-
--distribute_external false \
178-
--skip_waiting_for_build_processing false \
179-
--changelog "Build $MARKETING_VERSION ($CURRENT_PROJECT_VERSION)"
180-
181151
- name: Cleanup keychain
182152
if: always()
183153
run: |

app/ios/FareBot/Info.plist

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
<string>1</string>
2121
<key>LSRequiresIPhoneOS</key>
2222
<true/>
23+
<key>LSSupportsOpeningDocumentsInPlace</key>
24+
<true/>
25+
<key>ITSAppUsesNonExemptEncryption</key>
26+
<false/>
2327
<key>UIApplicationSceneManifest</key>
2428
<dict>
2529
<key>UIApplicationSupportsMultipleScenes</key>

0 commit comments

Comments
 (0)