Skip to content

Commit 9285c61

Browse files
author
Ian Gallagher
committed
Make Facebook/Twitter/Google handlers request over HTTPS
* This will make Firesheep requests of Facebook, Twitter, and Google encrypted, as to prevent the additional leaking of information. * Should also break how Firesheperd and Blacksheep currently detect Firesheep based on Facebook requests (though it's still certainly possible to detect and mess with it)
1 parent ea1130b commit 9285c61

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

xpi/handlers/facebook.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
// Authors:
22
// Eric Butler <[email protected]>
3+
// Ian Gallagher <[email protected]>
34
register({
45
name: 'Facebook',
5-
url: 'http://www.facebook.com/home.php',
6+
url: 'https://www.facebook.com/home.php',
67
domains: [ 'facebook.com' ],
78
sessionCookieNames: [ 'xs', 'c_user', 'sid' ],
89

@@ -11,4 +12,4 @@ register({
1112
this.userName = resp.body.querySelector('#navAccountName').innerHTML;
1213
this.userAvatar = resp.body.querySelector('#navAccountPic img').src;
1314
}
14-
});
15+
});

xpi/handlers/google.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ register({
1818
// Grab avatar from Google Profiles page, if they have one
1919
var avatar_element;
2020
try {
21-
var profile = this.httpGet('http://www.google.com/profiles/me');
21+
var profile = this.httpGet('https://www.google.com/profiles/me');
2222
avatar_element = profile.body.querySelector('.ll_profilephoto.photo');
2323
}
2424
catch(err) {

xpi/handlers/twitter.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
// Authors:
22
// Eric Butler <[email protected]>
3+
// Ian Gallagher <[email protected]>
34
Components.utils.import('resource://firesheep/util/RailsHelper.js');
45

56
register({
67
name: 'Twitter',
8+
url: 'https://twitter.com/',
79
domains: [ 'twitter.com' ],
810
sessionCookieNames: [ '_twitter_sess', 'auth_token' ],
911

@@ -33,4 +35,4 @@ register({
3335
this.userAvatar = resp.body.querySelector('#profile-image img').src;
3436
}
3537
}
36-
});
38+
});

0 commit comments

Comments
 (0)