Fix a bunch of type errors

Author: codebycruz

src/arisu.lua

@@ -46,14 +46,11 @@ function Arisu.run(appStatic)
 	window.Window.fromEventLoop(eventLoop)
 
 	eventLoop:run(function(event, handler)
-		handler:setMode("wait")
+		handler:setMode("poll")
 
 		local message = app:event(event, handler)
 		if message then
-			local task = app:update(message, event.window)
-			if task then
-				print("i have a task and i must run")
-			end
+			app:update(message, event.window)
 		end
 	end)
 end

src/bindings/gdi.lua

@@ -80,6 +80,7 @@ return {
 
 	---@type fun(): gdi.PIXELFORMATDESCRIPTOR
 	newPFD = function()
+		---@diagnostic disable-next-line: missing-return-value # ffi.new isn't typed properly for some reason
 		return ffi.new("PIXELFORMATDESCRIPTOR", {
 			nSize = ffi.sizeof("PIXELFORMATDESCRIPTOR"),
 			nVersion = 1,

src/bindings/gl.lua

@@ -96,6 +96,7 @@ if util.isUnix() then
 	local glx = require("bindings.glx")
 
 	function fetchNonCoreFn(name)
+		---@type function: We ensure nonCoreFnDefs has only function types
 		return ffi.cast(nonCoreFnDefs[name], glx.getProcAddress(name))
 	end
 else
@@ -194,7 +195,6 @@ return {
 	SYNC_GPU_COMMANDS_COMPLETE = 0x9117,
 	SYNC_FLUSH_COMMANDS_BIT = 0x00000001,
 
-	LESS = 0x0201,
 	LESS = 0x0201,
 	LESS_EQUAL = 0x0203,
 	GREATER = 0x0204,

src/bindings/user32.lua

@@ -137,13 +137,14 @@ ffi.cdef([[
 ---@field right number
 ---@field bottom number
 
+---@class user32.LPCSTR: ffi.cdata*
+
 local C = ffi.load("user32")
 
 return {
-	IDC_ARROW = ffi.cast("LPCSTR", 32512),
-	IDC_HAND = ffi.cast("LPCSTR", 32649),
-
-	IDI_APPLICATION = ffi.cast("LPCSTR", 32512),
+	IDC_ARROW = ffi.cast("LPCSTR", 32512) --[[@as user32.LPCSTR]],
+	IDC_HAND = ffi.cast("LPCSTR", 32649) --[[@as user32.LPCSTR]],
+	IDI_APPLICATION = ffi.cast("LPCSTR", 32512) --[[@as user32.LPCSTR]],
 
 	COLOR_WINDOW = 5,
 
@@ -280,6 +281,7 @@ return {
 
 	---@type fun(): user32.WNDCLASSEXA
 	newWndClassEx = function()
+		---@diagnostic disable-next-line: missing-return-value # ffi.new isn't typed properly for some reason
 		return ffi.new("WNDCLASSEXA", { cbSize = ffi.sizeof("WNDCLASSEXA") })
 	end,
 
@@ -294,10 +296,10 @@ return {
 	---@type fun(hwnd: user32.HWND, Msg: number, wParam: number, lParam: number): number
 	defWindowProc = C.DefWindowProcA,
 
-	---@type fun(hInstance: userdata, lpCursorName: string): userdata
+	---@type fun(hInstance: userdata?, lpCursorName: string | user32.LPCSTR): userdata
 	loadCursor = C.LoadCursorA,
 
-	---@type fun(hInstance: userdata, lpIconName: string): userdata
+	---@type fun(hInstance: userdata?, lpIconName: string | user32.LPCSTR): userdata
 	loadIcon = C.LoadIconA,
 
 	---@type fun(nIndex: number): userdata
@@ -308,8 +310,8 @@ return {
 		return C.AdjustWindowRect(lpRect, dwStyle, bMenu and 1 or 0) ~= 0
 	end,
 
-	---@type fun(): user32.RECT
 	newRect = function()
+		---@type user32.RECT
 		return ffi.new("RECT")
 	end,
 }

src/ui/element.lua

@@ -78,7 +78,7 @@ function Element:onClick(message)
 end
 
 ---@generic T
----@param cons fun(): T
+---@param cons fun(x: number, y: number, elementWidth: number, elementWidth: number): T
 function Element:onMouseDown(cons)
 	self.onmousedown = cons
 	return self

src/window/win32.lua

@@ -207,8 +207,6 @@ function Win32EventLoop:run(callback)
 			print("Error in event loop callback: " .. tostring(err))
 			os.exit(1)
 		end
-
-		return ok
 	end
 
 	for _, window in pairs(self.windows) do