Fix windows regressions

As I hoped, none of the changes broke windows specifically, beyond just
the untested change to lazily fetched GL functions to avoid having to
require the GL library at runtime which was nasty.

Beyond that, I just needed to support a consistent way for windows to
trigger a "create" event.

Right now both the callback and the window aren't registered in the
eventloop when the WM_CREATE real event is fired, so I couldn't use
that, in the future I'll investigate ways to try to mitigate this but
it's difficult.

Author: codebycruz

src/bindings/gl.lua

@@ -104,9 +104,10 @@ else
 	function fetchNonCoreFn(name)
 		local cached
 
-		return function(a, b, c, d, e, f, g, h, i, j)
+		-- todo: investigate if using varargs here will cause jit to fail
+		return function(...)
 			if cached then
-				return cached(a, b, c, d, e, f, g, h, i, j)
+				return cached(...)
 			end
 
 			local fn = ffi.cast(nonCoreFnDefs[name], wgl.getProcAddress(name))
@@ -115,7 +116,7 @@ else
 			end
 
 			cached = fn
-			return fn(a, b, c, d, e, f, g, h, i, j)
+			return fn(...)
 		end
 	end
 end

src/window/win32.lua

@@ -86,7 +86,6 @@ end
 ---@field currentMode "poll" | "wait"
 ---@field handler EventHandler
 ---@field callback fun(event: Event, handler: EventHandler)
----@field pendingCreates table<number, boolean>
 local Win32EventLoop = {}
 Win32EventLoop.__index = Win32EventLoop
 
@@ -97,23 +96,14 @@ function Win32EventLoop.new()
 	end
 
 	local class = user32.newWndClassEx()
-	local self = setmetatable({
-		class = class,
-		windows = {},
-		pendingCreates = {},
-	}, Win32EventLoop)
+	local self = setmetatable({ class = class, windows = {} }, Win32EventLoop)
 
 	class.lpszClassName = "ArisuWindow"
 	class.lpfnWndProc = user32.newWndProc(function(hwnd, msg, wParam, lParam)
 		if not self.callback then
 			return user32.defWindowProc(hwnd, msg, wParam, lParam)
 		end
 
-		if msg == user32.WM_CREATE then
-			self.pendingCreates[util.toPointer(hwnd)] = true
-			return 0
-		end
-
 		local window = self.windows[util.toPointer(hwnd)]
 
 		if not window then
@@ -199,13 +189,6 @@ end
 ---@param window Win32Window
 function Win32EventLoop:register(window)
 	self.windows[window.id] = window
-
-	if self.pendingCreates[window.id] then
-		self.callback({ name = "create", window = window }, self.handler)
-		self.callback({ name = "map", window = window }, self.handler)
-
-		self.pendingCreates[window.id] = nil
-	end
 end
 
 ---@param window Win32Window
@@ -228,6 +211,10 @@ function Win32EventLoop:run(callback)
 		return ok
 	end
 
+	for _, window in pairs(self.windows) do
+		self.callback({ name = "create", window = window }, self.handler)
+	end
+
 	local msg = user32.newMsg()
 	while self.isActive do
 		if self.currentMode == "poll" then