Don't use M_PI

Explicitly creating our own pi and tau

Author: codebycruz

src/constants.hpp

@@ -5,6 +5,9 @@
 #include "asset/asset.hpp"
 
 namespace constants {
+  constexpr float PI = 3.14159265358979323846f;
+  constexpr float TAU = 2 * PI;
+
   constexpr glm::vec3 WORLD_ORIGIN = glm::vec3(0.0f, 0.0f, 0.0f);
 
   // Coordinate system matching Unreal Engine

src/render/model/3d/sphere.cpp

@@ -1,8 +1,11 @@
 #include "sphere.hpp"
+
 #include <array>
 #include <cmath>
 #include <unordered_map>
 
+#include "constants.hpp"
+
 namespace {
   // Hash function for glm::vec3 to use in unordered_map
   struct Vec3Hash {
@@ -154,7 +157,7 @@ void model::Sphere::generateIcosphere(float radius, int subdivisions) {
 }
 
 glm::vec2 model::Sphere::calculateSphericalUV(const glm::vec3& normal) {
-  float u = 0.5f + std::atan2(normal.z, normal.x) / (2.0f * M_PI);
-  float v = 0.5f - std::asin(normal.y) / M_PI;
+  float u = 0.5f + std::atan2(normal.z, normal.x) / constants::TAU;
+  float v = 0.5f - std::asin(normal.y) / constants::PI;
   return glm::vec2(u, v);
 }