Fix no password support for old password protocol

Author: dougwilson

Changes.md

@@ -8,6 +8,7 @@ you spot any mistakes.
 
 * Fix `connection.threadId` missing on handshake failure
 * Fix duplicte packet name in debug output
+* Fix no password support for old password protocol
 * Remove special case for handshake in determine packet code
 * Small performance improvement starting command sequence
 

lib/protocol/Auth.js

@@ -86,6 +86,10 @@ Auth.myRnd = function(r){
 };
 
 Auth.scramble323 = function(message, password) {
+  if (!password) {
+    return Buffer.alloc(0);
+  }
+
   var to          = Buffer.allocUnsafe(8);
   var hashPass    = this.hashPassword(password);
   var hashMessage = this.hashPassword(message.slice(0, 8));

lib/protocol/packets/OldPasswordPacket.js

@@ -6,10 +6,9 @@ function OldPasswordPacket(options) {
 }
 
 OldPasswordPacket.prototype.parse = function(parser) {
-  this.scrambleBuff = parser.parseNullTerminatedBuffer();
+  this.scrambleBuff = parser.parsePacketTerminatedBuffer();
 };
 
 OldPasswordPacket.prototype.write = function(writer) {
   writer.writeBuffer(this.scrambleBuff);
-  writer.writeFiller(1);
 };

test/unit/connection/test-auth-no-old-password.js

@@ -0,0 +1,36 @@
+var assert     = require('assert');
+var common     = require('../../common');
+var connection = common.createConnection({
+  port         : common.fakeServerPort,
+  user         : 'root',
+  password     : null,
+  insecureAuth : true
+});
+
+var server = common.createFakeServer();
+
+server.listen(common.fakeServerPort, function (err) {
+  assert.ifError(err);
+
+  connection.connect(function (err) {
+    assert.ifError(err);
+    connection.destroy();
+    server.destroy();
+  });
+});
+
+server.on('connection', function(incomingConnection) {
+  incomingConnection.on('clientAuthentication', function () {
+    this._sendPacket(new common.Packets.UseOldPasswordPacket());
+  });
+
+  incomingConnection.on('OldPasswordPacket', function (packet) {
+    if (packet.scrambleBuff.length === 0) {
+      this.ok();
+    } else {
+      this.deny();
+    }
+  });
+
+  incomingConnection.handshake();
+});