Skip to content

Commit e01233f

Browse files
Merge pull request #126 from codecademy-engineering/lindsay-otel-fixes-2
fix more otel things
2 parents 6c2c739 + 7443f6a commit e01233f

File tree

4 files changed

+18
-13
lines changed

4 files changed

+18
-13
lines changed

charts/service/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: service
33
description: A generic k8s service chart
44
type: application
5-
version: 1.8.19
5+
version: 1.8.20
66
maintainers:
77
- email: devops@codecademy.com
88
name: devops

charts/service/templates/cronjob.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ spec:
2727
tags.datadoghq.com/service: {{ .service }}
2828
tags.datadoghq.com/version: {{ .version | quote }}
2929
{{- end }}
30+
{{- with $otel }}
31+
tags.datadoghq.com/env: {{ .env }}
32+
tags.datadoghq.com/service: {{ .service }}
33+
tags.datadoghq.com/version: {{ .version | quote }}
34+
{{- end }}
3035
spec:
3136
serviceAccountName: {{ $serviceAccountName }}
3237
containers:
@@ -72,15 +77,15 @@ spec:
7277
- name: OTEL_ENV
7378
valueFrom:
7479
fieldRef:
75-
fieldPath: metadata.labels['opentelemetry/env']
80+
fieldPath: metadata.labels['tags.datadoghq.com/env']
7681
- name: OTEL_SERVICE
7782
valueFrom:
7883
fieldRef:
79-
fieldPath: metadata.labels['opentelemetry/service']
84+
fieldPath: metadata.labels['tags.datadoghq.com/service']
8085
- name: OTEL_VERSION
8186
valueFrom:
8287
fieldRef:
83-
fieldPath: metadata.labels['opentelemetry/version']
88+
fieldPath: metadata.labels['tags.datadoghq.com/version']
8489
{{- end }}
8590
{{- if .envFromSecret }}
8691
envFrom:

charts/service/templates/deployment.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,15 @@ spec:
117117
- name: OTEL_ENV
118118
valueFrom:
119119
fieldRef:
120-
fieldPath: metadata.labels['opentelemetry/env']
120+
fieldPath: metadata.labels['tags.datadoghq.com/env']
121121
- name: OTEL_SERVICE
122122
valueFrom:
123123
fieldRef:
124-
fieldPath: metadata.labels['opentelemetry/service']
124+
fieldPath: metadata.labels['tags.datadoghq.com/service']
125125
- name: OTEL_VERSION
126126
valueFrom:
127127
fieldRef:
128-
fieldPath: metadata.labels['opentelemetry/version']
128+
fieldPath: metadata.labels['tags.datadoghq.com/version']
129129
{{- end }}
130130
{{- with .Values.initContainer.resources }}
131131
resources:
@@ -178,15 +178,15 @@ spec:
178178
- name: OTEL_ENV
179179
valueFrom:
180180
fieldRef:
181-
fieldPath: metadata.labels['opentelemetry/env']
181+
fieldPath: metadata.labels['tags.datadoghq.com/env']
182182
- name: OTEL_SERVICE
183183
valueFrom:
184184
fieldRef:
185-
fieldPath: metadata.labels['opentelemetry/service']
185+
fieldPath: metadata.labels['tags.datadoghq.com/service']
186186
- name: OTEL_VERSION
187187
valueFrom:
188188
fieldRef:
189-
fieldPath: metadata.labels['opentelemetry/version']
189+
fieldPath: metadata.labels['tags.datadoghq.com/version']
190190
{{- end }}
191191
{{- range $key, $value := .Values.envKeyValue }}
192192
- name: {{ $key }}

charts/service/templates/jobs.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ spec:
2828
{{- end }}
2929
{{- with $otel }}
3030
{{- if and .service .env }}
31-
opentelemetry/env: {{ .env }}
32-
opentelemetry/service: {{ .service }}
33-
opentelemetry/version: {{ .version | quote }}
31+
tags.datadoghq.com/env: {{ .env }}
32+
tags.datadoghq.com/service: {{ .service }}
33+
tags.datadoghq.com/version: {{ .version | quote }}
3434
{{- end }}
3535
{{- end }}
3636
spec:

0 commit comments

Comments
 (0)