Merge pull request #25 from flyingluscas/feature/categories-controller-tests

Categories controller tests

Author: vedovelli

webservice/app/Http/Controllers/CategoriesController.php

@@ -12,52 +12,96 @@ public function all(Request $request)
     {
         try {
             $pager = Category::paginate(10);
+
             return response()->json(compact('pager'), 200);
         } catch(\Exception $e) {
-            return response()->json(['messages' => ['List of categories not available']], 404);
+            return response()->json([
+                'messages' => ['Failed to fetch categories'],
+            ], 500);
         }
     }
 
     public function get($id)
     {
         try {
             $category = Category::find($id);
-            return response()->json(['result' => 'success', 'category' => $category], 200);
-        } catch(\Exception $e) {
-            return response()->json(['messages' => ['Category could not be fetched']], 404);
+
+            if (! $category) {
+                return response()->json([
+                    'messages' => ['Category not found'],
+                ], 404);
+            }
+
+            return response()->json([
+                'result' => 'success',
+                'category' => $category,
+            ], 200);
+        } catch (\Exception $e) {
+            return response()->json([
+                'messages' => ['Failed to fetch category'],
+            ], 500);
         }
     }
 
     public function create(CategoryRequest $request)
     {
         try {
             Category::create($request->only('name'));
-            return response()->json(['result' => 'success'], 200);
+
+            return response()->json([
+                'result' => 'success',
+            ], 200);
         } catch(\Exception $e) {
-            return response()->json(['messages' => ['Failed to create category']], 422);
+            return response()->json([
+                'messages' => ['Failed to create category'],
+            ], 500);
         }
     }
 
     public function update($id, CategoryRequest $request)
     {
         try {
             $category = Category::find($id);
+
+            if (! $category) {
+                return response()->json([
+                    'messages' => ['Category not found'],
+                ], 404);
+            }
+
             $category->name = $request->get('name');
             $category->save();
-            return response()->json(['result' => 'success'], 200);
+
+            return response()->json([
+                'result' => 'success',
+            ], 200);
         } catch (\Exception $e) {
-            return response()->json(['messages' => ['Failed to update category']], 422);
+            return response()->json([
+                'messages' => ['Failed to update category'],
+            ], 500);
         }
     }
 
     public function remove($id)
     {
         try {
             $category = Category::find($id);
+
+            if (! $category) {
+                return response()->json([
+                    'messages' => ['Category not found'],
+                ], 404);
+            }
+            
             $category->delete();
-            return response()->json(['result' => 'success'], 200);
+
+            return response()->json([
+                'result' => 'success',
+            ], 200);
         } catch (\Exception $e) {
-            return response()->json(['messages' => ['Failed to remove category']], 422);
+            return response()->json([
+                'messages' => ['Failed to remove category'],
+            ], 500);
         }
     }
 }

webservice/composer.json

@@ -50,7 +50,7 @@
             "Illuminate\\Foundation\\ComposerScripts::postUpdate",
             "php artisan optimize"
         ],
-        "test": "phpunit"
+        "test": "phpunit --colors=always"
     },
     "config": {
         "preferred-install": "dist"

webservice/tests/Controllers/CategoriesControllerTest.php

@@ -0,0 +1,130 @@
+<?php
+
+use App\Category;
+use Illuminate\Foundation\Testing\WithoutMiddleware;
+use Illuminate\Foundation\Testing\DatabaseMigrations;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class CategoriesControllerTest extends ApiTestCase
+{
+    use DatabaseMigrations, WithoutMiddleware, Factory;
+
+    /**
+     * @test
+     */
+    public function can_delete_category()
+    {
+        $this->create(Category::class);
+
+        $this->json('DELETE', '/api/categories/1/remove');
+
+        $this->assertResponseOk();
+        $this->dontSeeInDatabase('categories', ['id' => 1]);
+    }
+
+    /**
+     * @test
+     */
+    public function can_update_category()
+    {
+        $this->create(Category::class);
+
+        $this->json('PUT', '/api/categories/1/update', [
+            'name' => 'Dummy',
+        ]);
+
+        $this->assertResponseOk();
+        $this->seeInDatabase('categories', [
+            'id' => 1,
+            'name' => 'Dummy',
+        ]);
+    }
+
+    /**
+     * @test
+     * @dataProvider urlProvider
+     */
+    public function get_not_found_if_category_dont_exist($method, $url)
+    {
+        $this->json($method, $url, [
+            'name' => 'Dummy',
+        ]);
+
+        $this->assertResponseStatus(404);
+        $this->seeJsonStructure([
+            'messages' => [[]],
+        ]);
+    }
+
+    /**
+     * Url data privider.
+     *
+     * @return array
+     */
+    public function urlProvider()
+    {
+        return [
+            ['GET', '/api/categories/1/get'],
+            ['PUT', '/api/categories/1/update'],
+            ['DELETE', '/api/categories/1/remove'],
+        ];
+    }
+
+    /**
+     * @test
+     */
+    public function can_get_category()
+    {
+        $this->create(Category::class, [
+            'name' => 'Dummy',
+        ]);
+
+        $this->json('GET', '/api/categories/1/get');
+
+        $this->assertResponseOk();
+        
+        $this->seeJsonStructure([
+            'result', 'category' => [
+                'id', 'name',   
+            ],
+        ]); 
+        
+        $this->seeJson([
+            'name' => 'Dummy',
+        ]);
+    }
+
+    /**
+     * @test
+     */
+    public function can_create_category()
+    {
+        $this->json('POST', '/api/categories/create', [
+            'name' => 'Dummy name',
+        ]);
+
+        $this->assertResponseOk();
+        $this->seeInDatabase('categories', [
+            'name' => 'Dummy name',
+        ]);
+    }
+
+    /**
+     * @test
+     */
+    public function can_get_categories()
+    {
+        $this->times(3)->create(Category::class);
+
+        $this->json('GET', '/api/categories');
+
+        $this->assertResponseOk();
+        $this->seeJsonStructure([
+            'pager' => [
+                'data' => [
+                    '*' => ['id', 'name'],
+                ],
+            ],
+        ]);
+    }
+}