tests: remove unnecessary cleanup step

since all assistants have unique names the cleanup should not be necessary

existing buckets will not be created a second time

this is a step on the way to parallel test execution

Author: surt91

e2e/extension-tests/azure-open-ai-assistant-change.spec.ts

@@ -3,7 +3,6 @@ import { config } from '../tests/utils/config';
 import {
   addAzureModelToConfiguration,
   addSystemPromptToConfiguration,
-  cleanup,
   createConfiguration,
   deleteConfiguration,
   disableConfiguration,
@@ -24,7 +23,6 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
 
     await test.step('should login', async () => {
       await login(page);
-      await cleanup(page);
     });
     await test.step('should add two assistants', async () => {
       await enterAdminArea(page);

e2e/extension-tests/azure-open-ai-new-chat.spec.ts

@@ -4,7 +4,6 @@ import { config } from '../tests/utils/config';
 import {
   addAzureModelToConfiguration,
   checkSelectedConfiguration,
-  cleanup,
   createConfiguration,
   enterAdminArea,
   enterUserArea,
@@ -23,7 +22,6 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
     const configuration = { name: '', description: '' };
     await test.step('should login', async () => {
       await login(page);
-      await cleanup(page);
     });
 
     await test.step('add assistant', async () => {

e2e/extension-tests/azure-open-ai-search-file-in-chat.spec.ts

@@ -4,8 +4,7 @@ import {
   addAzureModelToConfiguration,
   addFilesInChatExtensionToConfiguration,
   addSystemPromptToConfiguration,
-  cleanup,
-  createBucket,
+  createBucketIfNotExist,
   createConfiguration,
   deleteFirstFileFromPaperclip,
   duplicateLastCreatedConversation,
@@ -31,7 +30,6 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
 
     await test.step('should login', async () => {
       await login(page);
-      await cleanup(page);
     });
 
     await test.step('add assistant', async () => {
@@ -41,7 +39,7 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
       await createConfiguration(page, configuration);
       await addAzureModelToConfiguration(page, configuration, { deployment: 'gpt-4o-mini' });
       await addSystemPromptToConfiguration(page, configuration, { text: 'Your are a helpful assistant.' });
-      await createBucket(page, {
+      await createBucketIfNotExist(page, {
         name: conversationFilesBucket,
         type: 'conversation',
         endpoint: config.REIS_ENDPOINT,

e2e/extension-tests/azure-open-ai-whole-file.spec.ts

@@ -7,8 +7,7 @@ import {
   addSystemPromptToConfiguration,
   addVisionFileExtensionToConfiguration,
   addWholeFileExtensionToConfiguration,
-  cleanup,
-  createBucket,
+  createBucketIfNotExist,
   createConfiguration,
   deactivateFileInChatExtensionToConfiguration,
   deleteFirstFileFromPaperclip,
@@ -34,7 +33,6 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
 
     await test.step('should login', async () => {
       await login(page);
-      await cleanup(page);
     });
 
     await test.step('add assistant', async () => {
@@ -53,7 +51,7 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
     });
 
     await test.step('should add whole file extension to Assistant', async () => {
-      await createBucket(page, {
+      await createBucketIfNotExist(page, {
         name: conversationFilesBucket,
         type: 'conversation',
         endpoint: config.REIS_ENDPOINT,

e2e/extension-tests/azure-open-ai.spec.ts

@@ -4,8 +4,7 @@ import {
   addAzureModelToConfiguration,
   addBucketToConfiguration,
   addSystemPromptToConfiguration,
-  cleanup,
-  createBucket,
+  createBucketIfNotExist,
   createConfiguration,
   editBucket,
   enterAdminArea,
@@ -28,7 +27,6 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
 
     await test.step('should login', async () => {
       await login(page);
-      await cleanup(page);
     });
     await test.step('should not add Configuration without required fields', async () => {
       await enterAdminArea(page);
@@ -108,7 +106,7 @@ if (!config.AZURE_OPEN_AI_API_KEY) {
 
     await test.step('should create bucket', async () => {
       await enterAdminArea(page);
-      await createBucket(page, {
+      await createBucketIfNotExist(page, {
         name: bucket.name,
         type: 'user',
         endpoint: config.REIS_ENDPOINT,

e2e/extension-tests/viewport.spec.ts

@@ -2,7 +2,6 @@ import test, { expect } from '@playwright/test';
 import { sseBodyABC, sseBodyBanana } from '../tests/utils/files/sse-responses';
 import {
   addAzureModelToConfiguration,
-  cleanup,
   createConfiguration,
   enterAdminArea,
   enterUserArea,
@@ -44,7 +43,6 @@ test('Chat viewport scrolling', async ({ page }) => {
 
   await test.step('should login', async () => {
     await login(page);
-    await cleanup(page);
   });
 
   await test.step('should add mock assistant', async () => {

e2e/tests/utils/helper.ts

@@ -146,11 +146,15 @@ export async function clearMessages(page: Page) {
   await confirm.waitFor({ state: 'detached' });
 }
 
-export async function createBucket(
+export async function createBucketIfNotExist(
   page: Page,
   bucket: { name: string; indexName?: string; endpoint: string; type: 'user' | 'conversation' | 'general' },
 ) {
   await page.getByRole('link', { name: 'Files' }).click();
+  if (await page.locator('li').filter({ hasText: bucket.name }).getByTestId('more-actions').count()) {
+    // Bucket already exists
+    return;
+  }
 
   await page
     .locator('*')