feat: reformat code, add tests for next case

Author: ChristianSauer

CodeQualityToGitlab/Transform.cs

@@ -48,7 +48,7 @@ private static void Process(
         {
             var toTransform = match.Path;
             Log.Information("Processing: {File}", toTransform);
-            var cqrs = processFunc(new FileInfo(toTransform), pathRoot);
+            var cqrs = processFunc(new(toTransform), pathRoot);
             allIssues.AddRange(cqrs);
         }
     }

Test/Test.csproj

@@ -72,6 +72,9 @@
         <Content Include="crash.sarif.json">
           <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </Content>
+        <Content Include="codeanalysis.sarif4.json">
+            <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+        </Content>
         <None Update="codeanalysis.sarif21.json">
           <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>

Test/TestSarif.cs

@@ -8,6 +8,13 @@ namespace Test;
 
 public class TestSarif
 {
+    private static readonly JsonSerializerOptions JsonSerializerOptions = new()
+    {
+        WriteIndented = true,
+        PropertyNamingPolicy = new LowerCaseNamingPolicy(),
+        Converters = { new JsonStringEnumConverter() }
+    };
+
     [Fact]
     public void TestSarifWorks()
     {
@@ -20,12 +27,7 @@ public void TestSarifWorks()
             $"C:{Path.DirectorySeparatorChar}dev" + Path.DirectorySeparatorChar
         );
 
-        var options = new JsonSerializerOptions
-        {
-            WriteIndented = true,
-            PropertyNamingPolicy = new LowerCaseNamingPolicy(),
-            Converters = { new JsonStringEnumConverter() }
-        };
+        var options = JsonSerializerOptions;
 
         using var r = new StreamReader(target.FullName);
         var json = r.ReadToEnd();
@@ -52,12 +54,7 @@ public void TestSarifWorks2()
 
         SarifConverter.ConvertToCodeQuality(source, target);
 
-        var options = new JsonSerializerOptions
-        {
-            WriteIndented = true,
-            PropertyNamingPolicy = new LowerCaseNamingPolicy(),
-            Converters = { new JsonStringEnumConverter() }
-        };
+        var options = JsonSerializerOptions;
 
         using var r = new StreamReader(target.FullName);
         var json = r.ReadToEnd();
@@ -73,28 +70,6 @@ public void TestSarifWorks2()
         codeQuality.Location.Lines.Begin.Should().Be(26);
     }
 
-    [Fact]
-    public void TestSarifWorks3()
-    {
-        var source = new FileInfo("codeanalysis.sarif3.json");
-        var target = new FileInfo(Path.GetTempFileName());
-
-        SarifConverter.ConvertToCodeQuality(source, target);
-
-        var options = new JsonSerializerOptions
-        {
-            WriteIndented = true,
-            PropertyNamingPolicy = new LowerCaseNamingPolicy(),
-            Converters = { new JsonStringEnumConverter() }
-        };
-
-        using var r = new StreamReader(target.FullName);
-        var json = r.ReadToEnd();
-        var result = JsonSerializer.Deserialize<List<CodeQuality>>(json, options);
-
-        result.Should().HaveCount(0);
-    }
-
     [Fact]
     public void TestCrashWorks()
     {
@@ -103,12 +78,7 @@ public void TestCrashWorks()
 
         SarifConverter.ConvertToCodeQuality(source, target);
 
-        var options = new JsonSerializerOptions
-        {
-            WriteIndented = true,
-            PropertyNamingPolicy = new LowerCaseNamingPolicy(),
-            Converters = { new JsonStringEnumConverter() }
-        };
+        var options = JsonSerializerOptions;
 
         using var r = new StreamReader(target.FullName);
         var json = r.ReadToEnd();
@@ -125,12 +95,7 @@ public void TestSarif21Works()
 
         SarifConverter.ConvertToCodeQuality(source, target);
 
-        var options = new JsonSerializerOptions
-        {
-            WriteIndented = true,
-            PropertyNamingPolicy = new LowerCaseNamingPolicy(),
-            Converters = { new JsonStringEnumConverter() }
-        };
+        var options = JsonSerializerOptions;
 
         using var r = new StreamReader(target.FullName);
         var json = r.ReadToEnd();

Test/TestTransform.cs

@@ -27,4 +27,25 @@ public void TestTransformAllWorks()
 
         result.Should().HaveCount(8);
     }
+
+    [Fact]
+    public void TestTransformCreatesExpectedPath()
+    {
+        var target = new FileInfo(Path.GetTempFileName());
+
+        Transform.TransformAll("codeanalysis.sarif4.json", "", target, null, true);
+
+        var options = new JsonSerializerOptions
+        {
+            WriteIndented = true,
+            PropertyNamingPolicy = new LowerCaseNamingPolicy(),
+            Converters = { new JsonStringEnumConverter() }
+        };
+
+        using var r = new StreamReader(target.FullName);
+        var json = r.ReadToEnd();
+        var result = JsonSerializer.Deserialize<List<CodeQuality>>(json, options);
+
+        result.Should().HaveCount(8);
+    }
 }