Merge pull request #5 from mpidash/sarif-check-suppression-states

Skip results where SuppressionStates is not None

Author: ChristianSauer

CodeQualityToGitlab/SarifConverter.cs

@@ -19,36 +19,40 @@ public static List<CodeQuality> ConvertToCodeQualityRaw(FileInfo source, string?
 
         var log = JsonConvert.DeserializeObject<SarifLogVersionOne>(logContents, settings);
 
-        var cqrs = new List<CodeQuality>();
-        foreach (var result in log.Runs.SelectMany(x => x.Results))
+        var results = log.Runs
+            .SelectMany(x => x.Results)
+            .Where(r => r.SuppressionStates == SuppressionStatesVersionOne.None);
+
+		var cqrs = new List<CodeQuality>();
+		foreach (var result in results)
         {
             var begin = result.Locations?.FirstOrDefault();
 
-                if (begin == null)
-                {
-                    Log.Warning("An issue has no location, skipping: {Result}", result.Message);
-                    continue;
-                }
+            if (begin == null)
+            {
+                Log.Warning("An issue has no location, skipping: {Result}", result.Message);
+                continue;
+            }
 
-                try
+			try
+            {
+                var cqr = new CodeQuality
                 {
-                    var cqr = new CodeQuality
+                    Description = $"{result.RuleId}: {result.Message}",
+                    Severity = GetSeverity(result.Level),
+                    Location = new LocationCq
                     {
-                        Description = $"{result.RuleId}: {result.Message}",
-                        Severity = GetSeverity(result.Level),
-                        Location = new LocationCq
-                        {
-                            Path = GetPath(pathRoot, begin),
-                            Lines = new Lines { Begin = begin.ResultFile.Region.StartLine }
-                        },
-                        Fingerprint = Common.GetHash($"{result.RuleId}|{begin.ResultFile.Uri}|{begin.ResultFile.Region.StartLine}")
-                    };
-                    cqrs.Add(cqr);
-                }
-                catch (Exception e)
-                {
-                   Log.Error(e, "Could not convert {@Result}, skipping", result);
-                }
+                        Path = GetPath(pathRoot, begin),
+                        Lines = new Lines { Begin = begin.ResultFile.Region.StartLine }
+                    },
+                    Fingerprint = Common.GetHash($"{result.RuleId}|{begin.ResultFile.Uri}|{begin.ResultFile.Region.StartLine}")
+                };
+                cqrs.Add(cqr);
+            }
+            catch (Exception e)
+            {
+                Log.Error(e, "Could not convert {@Result}, skipping", result);
+            }
         }
 
         return cqrs;

Test/TestSarif.cs

@@ -86,10 +86,7 @@ public void TestSarifWorks3()
         var json = r.ReadToEnd();
         var result = JsonSerializer.Deserialize<List<CodeQuality>>(json, options);
 
-        result.Should().HaveCount(1);
-        var codeQuality = result!.First();
-        codeQuality.Location.Path.Should().Be("Microsoft.NET.Sdk.Razor.SourceGenerators/Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator/Views_Apaleo_TgcBooking_cshtml.g.cs");
-        codeQuality.Location.Lines.Begin.Should().Be(217);
+        result.Should().HaveCount(0);
 
     }