Skip to content

Commit 0bb60bb

Browse files
committed
fix: Adjust README instructions
1 parent 64630bb commit 0bb60bb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
# From Jupyter to Production
22

3-
JupyterLab image for workshop: From Jupyter to Production - production-ready data science projects.
3+
JupyterLab and Mlflow image for workshop: From Jupyter to Production - production-ready data science projects.
44

55
https://github.com/codecentric/from-jupyter-to-production-workshop
66

77
## Build & Push
88

9-
A github action is defined to push a new version of the image to docker hub for every new commit to the repository. No need to do anything locally, besides testing the build with `docker build .`
9+
A github action is defined to push a new version of the image to Docker Hub every time a new `git tag` is pushed to the repository.
10+
The git tag is also used for the Docker images. An image tag with the git tag and the `latest` tag is published for each Docker build.
11+
No need to do anything locally, besides testing the build with `docker build .`
1012

1113
The build is quite memory heavy, so assign a good amount of memory towards the docker engine (minimum 4gb, better 6gb)
1214

@@ -15,15 +17,13 @@ The build is quite memory heavy, so assign a good amount of memory towards the d
1517
Run in `from-jupyter-to-production-workshop` directory, containing the notebooks.
1618

1719
```bash
18-
docker run -p 8888:8888 -v $(pwd)/notebooks:/workshop/notebooks radtkem/from-jupyter-to-production-baseimage
20+
docker run -p 8888:8888 -v $(pwd)/notebooks:/workshop/notebooks radtkem/from-jupyter-to-production-jupyter
1921
```
2022

21-
*Note: Running on Apple Silicon/M1 is currently not supported*
22-
2323
## Run on Windows
2424

2525
Run in `from-jupyter-to-production-workshop` directory, containing the notebooks.
2626

2727
```bash
28-
docker run -p 8888:8888 -v %cd%/notebooks:/workshop/notebooks radtkem/from-jupyter-to-production-baseimage
28+
docker run -p 8888:8888 -v %cd%/notebooks:/workshop/notebooks radtkem/from-jupyter-to-production-jupyter
2929
```

0 commit comments

Comments
 (0)