Show the "new update" notice only when the new version has a higher number 😉

Author: Matthias Rütten

package.json

@@ -97,6 +97,7 @@
     "@types/webdriverio": "^5.0.0",
     "@types/webpack-env": "^1.13.3",
     "babel-loader": "^8.0.6",
+    "compare-versions": "^3.5.1",
     "copy-webpack-plugin": "^5.0.4",
     "cross-env": "^6.0.0",
     "css-loader": "^3.2.0",

src/renderer/components/Content.tsx

@@ -7,12 +7,10 @@ import { MergeRequestsPage } from './merge-requests/MergeRequestsPage'
 import { SettingsPage } from './settings/SettingsPage'
 import { AboutUsPage } from './about-us/AboutUsPage'
 import { UpdateInfoPage } from './update/UpdateInfoPage'
-import { useUpdater } from '../hooks/updater'
 import { NewUpdateAlert } from './update/NewUpdateAlert'
 
 export const Content: React.FunctionComponent = () => {
     const { config } = useConfig()
-    const { updateInfo } = useUpdater()
 
     return (
         <Box>
@@ -28,7 +26,7 @@ export const Content: React.FunctionComponent = () => {
                 </Route>
                 {config ? (
                     <Route path='/'>
-                        {updateInfo && <NewUpdateAlert />}
+                        <NewUpdateAlert />
                         <MergeRequestsPage />
                     </Route>
                 ) : (

src/renderer/components/update/NewUpdateAlert.tsx

@@ -1,8 +1,19 @@
 import * as React from 'react'
 import { Box, Flex, Text } from 'rebass'
 import { Link } from 'react-router-dom'
+import { remote } from 'electron'
+import * as compareVersions from 'compare-versions'
+
+import { useUpdater } from '../../hooks/updater'
 
 export const NewUpdateAlert = () => {
+    const currentVersion = remote.app.getVersion()
+    const { updateInfo } = useUpdater()
+
+    if (!updateInfo || compareVersions(updateInfo.updateInfo.version, currentVersion) < 1) {
+        return null
+    }
+
     return (
         <Box py={1} px={2} sx={{ position: 'sticky', zIndex: 2, top: 0, borderBottom: '1px solid', borderColor: 'shadow' }} bg='siteBackground'>
             <Text fontWeight='bold' color='red' letterSpacing={1} sx={{ textTransform: 'uppercase' }} fontSize={'12px'}>

yarn.lock

@@ -2936,6 +2936,11 @@ commondir@^1.0.1:
   resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
   integrity sha1-3dgA2gxmEnOTzKWVDqloo6rxJTs=
 
+compare-versions@^3.5.1:
+  version "3.5.1"
+  resolved "https://registry.yarnpkg.com/compare-versions/-/compare-versions-3.5.1.tgz#26e1f5cf0d48a77eced5046b9f67b6b61075a393"
+  integrity sha512-9fGPIB7C6AyM18CJJBHt5EnCZDG3oiTJYy0NjfIAGjKpzv0tkxWko7TNQHF5ymqm7IH03tqmeuBxtvD+Izh6mg==
+
 component-emitter@^1.2.1, component-emitter@^1.3.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/component-emitter/-/component-emitter-1.3.0.tgz#16e4070fba8ae29b679f2215853ee181ab2eabc0"