#4236: make ignore check case-insensitive (#4256)

Author: erikpetzold

spring-boot-admin-docs/src/site/docs/server/01-server.md

@@ -73,7 +73,7 @@ __Discovery configuration options__
 | spring.boot.admin.discovery.enabled                           | Enables the DiscoveryClient-support for the admin server.                                                                                         | true          |
 | spring.boot.admin.discovery.converter.management-context-path | Will be appended to the service-url of the discovered service when the management-url is converted by the DefaultServiceInstanceConverter.        | /actuator     |
 | spring.boot.admin.discovery.converter.health-endpoint-path    | Will be appended to the management-url of the discovered service when the health-url is converted by the DefaultServiceInstanceConverter.         | "health"      |
-| spring.boot.admin.discovery.ignored-services                  | This services will be ignored when using discovery and not registered as application. Supports simple patterns (e.g. "foo*", "*bar", "foo*bar*"). |               |
+| spring.boot.admin.discovery.ignored-services                  | This services will be ignored when using discovery and not registered as application. Supports simple patterns (e.g. "foo*", "*bar", "foo*bar*"). The check is case-insensitive. |               |
 | spring.boot.admin.discovery.services                          | This services will be included when using discovery and registered as application. Supports simple patterns (e.g. "foo*", "*bar", "foo*bar*").    | "*"           |
 | spring.boot.admin.discovery.ignored-instances-metadata        | Instances of services will be ignored if they contain at least one metadata item that matches this list. (e.g. "discoverable=false")              |               |
 | spring.boot.admin.discovery.instances-metadata                | Instances of services will be included if they contain at least one metadata item that matches this list. (e.g. "discoverable=true")              |               |

spring-boot-admin-server-cloud/src/main/java/de/codecentric/boot/admin/server/cloud/discovery/InstanceDiscoveryListener.java

@@ -160,7 +160,8 @@ protected boolean shouldRegisterService(final String serviceId) {
 	}
 
 	protected boolean matchesPattern(String serviceId, Set<String> patterns) {
-		return patterns.stream().anyMatch((pattern) -> PatternMatchUtils.simpleMatch(pattern, serviceId));
+		return patterns.stream()
+			.anyMatch((pattern) -> PatternMatchUtils.simpleMatch(pattern.toLowerCase(), serviceId.toLowerCase()));
 	}
 
 	protected boolean shouldRegisterInstanceBasedOnMetadata(ServiceInstance instance) {

spring-boot-admin-server-cloud/src/test/java/de/codecentric/boot/admin/server/cloud/discovery/InstanceDiscoveryListenerTest.java

@@ -91,6 +91,18 @@ public void should_not_register_instance_when_serviceId_is_ignored() {
 		StepVerifier.create(this.registry.getInstances()).verifyComplete();
 	}
 
+	@Test
+	public void should_not_register_instance_when_serviceId_is_ignored_caseInsensitive() {
+		when(this.discovery.getServices()).thenReturn(singletonList("service"));
+		when(this.discovery.getInstances("service"))
+			.thenReturn(singletonList(new DefaultServiceInstance("test-1", "service", "localhost", 80, false)));
+
+		this.listener.setIgnoredServices(singleton("SERVICE"));
+		this.listener.onInstanceRegistered(new InstanceRegisteredEvent<>(new Object(), null));
+
+		StepVerifier.create(this.registry.getInstances()).verifyComplete();
+	}
+
 	@Test
 	public void should_not_register_instance_when_instanceMetadata_is_ignored() {
 		when(this.discovery.getServices()).thenReturn(singletonList("service"));