Skip to content

Commit 0971ac9

Browse files
Copilotkobenguyent
andcommitted
Changes before error encountered
Co-authored-by: kobenguyent <[email protected]>
1 parent ff8d52e commit 0971ac9

File tree

2 files changed

+19
-11
lines changed

2 files changed

+19
-11
lines changed

.github/workflows/acceptance-tests.yml

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,21 +81,29 @@ jobs:
8181
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
8282
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
8383

84-
- name: Install Puppeteer Browser
85-
if: contains(matrix.config, 'Puppeteer')
86-
run: npx puppeteer browsers install chrome
84+
- name: Setup Chrome
85+
uses: browser-actions/setup-chrome@v1
8786

8887
- name: Install Playwright Browsers
8988
if: contains(matrix.config, 'Playwright')
90-
run: npx playwright install chromium && npx playwright install-deps
89+
run: npx playwright install chromium --with-deps
90+
91+
- name: Verify browser setup
92+
run: |
93+
which google-chrome || which chromium-browser || echo "Chrome not found in PATH"
9194
9295
- name: Start PHP Server
93-
run: php -S 127.0.0.1:8000 -t test/data/app &
96+
run: |
97+
php -S 127.0.0.1:8000 -t test/data/app &
98+
sleep 2
99+
# Wait for server to be ready
100+
timeout 10 bash -c 'until curl -s http://127.0.0.1:8000 >/dev/null; do sleep 1; done' || echo "Server may not be fully ready"
94101
95102
- name: Run Acceptance Tests with Sharding
96103
run: npx codeceptjs run --config ./test/acceptance/${{ matrix.config }} --shard ${{ matrix.shard }} --verbose
97104
env:
98105
FORCE_COLOR: 1
106+
DONT_FAIL_ON_EMPTY_RUN: true
99107

100108
- name: Display Test Info
101109
run: |

.github/workflows/sharding-demo.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ env:
1313
FORCE_COLOR: 1
1414

1515
jobs:
16-
# Demonstrate sharding with a larger test suite (sandbox tests)
16+
# Demonstrate sharding with sandbox tests (FileSystem-based, no browser needed)
1717
sharded-sandbox-tests:
1818
runs-on: ubuntu-latest
1919
name: 'Sandbox Tests (Shard ${{ matrix.shard }})'
@@ -22,7 +22,7 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
node-version: [20.x]
25-
# Split 2 sandbox tests across 2 shards for demonstration
25+
# Split sandbox tests across 2 shards
2626
shard: ['1/2', '2/2']
2727

2828
steps:
@@ -35,10 +35,10 @@ jobs:
3535
node-version: ${{ matrix.node-version }}
3636

3737
- name: Install dependencies
38-
run: npm install
38+
run: npm install --ignore-scripts
3939

4040
- name: Run Sandbox Tests with Sharding
41-
run: npx codeceptjs run --config ./test/data/sandbox/codecept.js --shard ${{ matrix.shard }} --verbose
41+
run: npx codeceptjs run --config ./codecept.js --shard ${{ matrix.shard }} --verbose
4242
working-directory: test/data/sandbox
4343
env:
4444
FORCE_COLOR: 1
@@ -70,10 +70,10 @@ jobs:
7070
node-version: ${{ matrix.node-version }}
7171

7272
- name: Install dependencies
73-
run: npm install
73+
run: npm install --ignore-scripts
7474

7575
- name: Run Tests with Shuffle + Sharding
76-
run: npx codeceptjs run --config ./test/data/sandbox/codecept.js --shuffle --shard ${{ matrix.shard }} --verbose
76+
run: npx codeceptjs run --config ./codecept.js --shuffle --shard ${{ matrix.shard }} --verbose
7777
working-directory: test/data/sandbox
7878
env:
7979
FORCE_COLOR: 1

0 commit comments

Comments
 (0)