fix: add missing return statement for XPath in findElements

kobenguyent · kobenguyent · commit 2ff912e6b3b9 · 2025-11-04T09:56:05.000Z
- Fixed findElements to return matcher.$x(locator.value) for newer Puppeteer versions
- This was causing 'Cannot read properties of undefined (reading length)' errors
diff --git a/lib/helper/Puppeteer.js b/lib/helper/Puppeteer.js
@@ -2871,6 +2871,8 @@ async function findElements(matcher, locator) {
   if (puppeteer.default?.defaultBrowserRevision) {
     return matcher.$$(`xpath/${locator.value}`)
   }
+  // For newer Puppeteer versions, use $x for XPath
+  return matcher.$x(locator.value)
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -2871,6 +2871,8 @@ async function findElements(matcher, locator) {`
`2871`	`2871`	`if (puppeteer.default?.defaultBrowserRevision) {`
`2872`	`2872`	return matcher.$$(`xpath/${locator.value}`)
`2873`	`2873`	`}`
	`2874`	`+ // For newer Puppeteer versions, use $x for XPath`
	`2875`	`+ return matcher.$x(locator.value)`
`2874`	`2876`	`}`
`2875`	`2877`
`2876`	`2878`	`/**`