fix(webapi): selectOption method (#4157)

dyaroman · web-flow · commit 48370734cf39 · 2024-01-26T15:38:12.000+01:00
trim text content value
diff --git a/lib/helper/Playwright.js b/lib/helper/Playwright.js
@@ -1805,7 +1805,7 @@ class Playwright extends Helper {
     let optionToSelect = '';
 
     try {
-      optionToSelect = await el.locator('option', { hasText: option }).textContent();
+      optionToSelect = (await el.locator('option', { hasText: option }).textContent()).trim();
     } catch (e) {
       optionToSelect = option;
     }
diff --git a/test/data/app/view/form/select_additional_spaces.php b/test/data/app/view/form/select_additional_spaces.php
@@ -0,0 +1,25 @@
+<html>
+<body>
+<form action="/form/complex" method="POST">
+    <label for="age">Select your age</label>
+    <select name="age" id="age">
+        <option value="child">
+            below 13
+        </option>
+        <option value="teenage">
+            13-21
+        </option>
+        <option value="adult">
+            21-60
+        </option>
+        <option value="oldfag" selected="selected">
+            60-100
+        </option>
+        <option value="dead">
+            100-210
+        </option>
+    </select>
+    <input type="submit" value="Submit" />
+</form>
+</body>
+</html>
diff --git a/test/helper/webapi.js b/test/helper/webapi.js
@@ -433,6 +433,13 @@ module.exports.tests = function () {
       await I.click('Submit');
       assert.deepEqual(formContents('like'), ['play', 'adult']);
     });
+
+    it('should select option by label and option text with additional spaces', async () => {
+      await I.amOnPage('/form/select_additional_spaces');
+      await I.selectOption('Select your age', '21-60');
+      await I.click('Submit');
+      assert.equal(formContents('age'), 'adult');
+    });
   });
 
   describe('#executeScript', () => {

Original file line number	Diff line number	Diff line change
`@@ -1805,7 +1805,7 @@ class Playwright extends Helper {`
`1805`	`1805`	`let optionToSelect = '';`
`1806`	`1806`
`1807`	`1807`	`try {`
`1808`		`- optionToSelect = await el.locator('option', { hasText: option }).textContent();`
	`1808`	`+ optionToSelect = (await el.locator('option', { hasText: option }).textContent()).trim();`
`1809`	`1809`	`} catch (e) {`
`1810`	`1810`	`optionToSelect = option;`
`1811`	`1811`	`}`