Skip to content

Commit 5cb3129

Browse files
committed
run helpers UTs before acceptance tests
1 parent 071c414 commit 5cb3129

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

.github/workflows/playwright.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ jobs:
4646
timeout-minutes: 2
4747
- name: start a server
4848
run: 'php -S 127.0.0.1:8000 -t test/data/app &'
49+
- name: run chromium unit tests
50+
run: ./node_modules/.bin/mocha test/helper/Playwright_test.js --timeout 5000 --reporter @testomatio/reporter/mocha
51+
timeout-minutes: 5
4952
- name: run chromium tests
5053
run: 'timeout 600 bash -c "unset BROWSER && BROWSER=chromium ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug"'
5154
timeout-minutes: 12
@@ -61,8 +64,5 @@ jobs:
6164
- name: run webkit tests
6265
run: 'timeout 600 bash -c "unset BROWSER && BROWSER=webkit node ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug"'
6366
timeout-minutes: 12
64-
- name: run chromium unit tests
65-
run: ./node_modules/.bin/mocha test/helper/Playwright_test.js --timeout 5000 --reporter @testomatio/reporter/mocha
66-
timeout-minutes: 5
6767
env:
6868
GH_PAT: ${{ github.token }}

.github/workflows/puppeteer.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ jobs:
4040
run: 'php -S 127.0.0.1:8000 -t test/data/app &'
4141
- uses: browser-actions/setup-chrome@v1
4242
- run: chrome --version
43-
- name: run tests
44-
run: 'timeout 600 bash -c "./bin/codecept.js run-workers 2 -c test/acceptance/codecept.Puppeteer.js --grep @Puppeteer --debug"'
45-
timeout-minutes: 12
4643
- name: run unit tests
4744
run: ./node_modules/.bin/mocha test/helper/Puppeteer_test.js --reporter @testomatio/reporter/mocha
4845
timeout-minutes: 5
46+
- name: run tests
47+
run: 'timeout 600 bash -c "./bin/codecept.js run-workers 2 -c test/acceptance/codecept.Puppeteer.js --grep @Puppeteer --debug"'
48+
timeout-minutes: 12
4949
env:
5050
GH_PAT: ${{ github.token }}

.github/workflows/webdriver.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ jobs:
3939
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
4040
- name: start a server
4141
run: 'php -S 127.0.0.1:8000 -t test/data/app &'
42-
- name: check
43-
run: './bin/codecept.js check -c test/acceptance/codecept.WebDriver.js'
44-
timeout-minutes: 2
4542
- name: run unit tests
4643
run: ./node_modules/.bin/mocha test/helper/WebDriver_test.js --exit --reporter @testomatio/reporter/mocha
4744
timeout-minutes: 5
45+
- name: check
46+
run: './bin/codecept.js check -c test/acceptance/codecept.WebDriver.js'
47+
timeout-minutes: 2
4848
env:
4949
GH_PAT: ${{ github.token }}
5050
- name: run tests

test/acceptance/within_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ Scenario('switch iframe manually @WebDriverIO @Puppeteer @Playwright', ({ I }) =
2424
I.dontSee('Email Address')
2525
})
2626

27-
Scenario('within on iframe @WebDriverIO @Puppeteer @Playwright', ({ I }) => {
27+
Scenario('within on iframe @WebDriverIO @Puppeteer @Playwright', async ({ I }) => {
2828
I.amOnPage('/iframe')
29-
within({ frame: 'iframe' }, async () => {
29+
await within({ frame: 'iframe' }, async () => {
3030
await I.fillField('rus', 'Updated')
3131
await I.click('Sign in!')
3232
await I.waitForText('Email Address')

0 commit comments

Comments
 (0)