fix share workers

Author: kobenguyent

test/data/sandbox/workers-proxy-issue/README.md

@@ -0,0 +1,48 @@
+# Test Suite for Issue #5066 Fix
+
+This directory contains tests that validate the fix for **Issue #5066: Unable to inject data between workers because of proxy object**.
+
+## Test Files
+
+### `proxy_test.js`
+Basic tests that verify the core functionality of `share()` and `inject()` functions:
+- Basic data sharing with primitive types (strings, numbers)
+- Complex nested data structures (objects, arrays)
+- Property access patterns that should work after the fix
+
+### `final_test.js`
+Comprehensive end-to-end validation test that covers:
+- Multiple data types and structures
+- Data overriding scenarios
+- Deep nested property access
+- Key enumeration functionality
+- Real-world usage patterns
+
+## Running the Tests
+
+### Single-threaded execution:
+```bash
+npx codeceptjs run proxy_test.js
+npx codeceptjs run final_test.js
+```
+
+### Multi-worker execution (tests worker communication):
+```bash
+npx codeceptjs run-workers 2 proxy_test.js
+npx codeceptjs run-workers 2 final_test.js
+```
+
+## What the Fix Addresses
+
+1. **Circular Dependency Error**: Fixed "Support object undefined is not defined" error in `workerStorage.js`
+2. **Proxy System Enhancement**: Updated container proxy system to handle dynamically shared data
+3. **Worker Communication**: Ensured data sharing works correctly between worker threads
+4. **Key Enumeration**: Made sure `Object.keys(inject())` shows shared properties
+
+## Expected Results
+
+All tests should pass in both single-threaded and multi-worker modes, demonstrating that:
+- `share({ data })` correctly shares data between workers
+- `inject()` returns a proxy object with proper access to shared data
+- Both direct property access and nested object traversal work correctly
+- Key enumeration shows all shared properties

test/data/sandbox/workers-proxy-issue/codecept.conf.js

@@ -0,0 +1,10 @@
+exports.config = {
+  tests: './proxy_test.js',
+  output: './output',
+  helpers: {
+    FileSystem: {}
+  },
+  include: {},
+  mocha: {},
+  name: 'workers-proxy-issue',
+};

test/data/sandbox/workers-proxy-issue/final_test.js

@@ -0,0 +1,60 @@
+const assert = require('assert');
+
+Feature('Complete validation for issue #5066 fix');
+
+Scenario('End-to-end worker data sharing validation', () => {
+  console.log('=== Testing complete data sharing workflow ===');
+  
+  // Test 1: Basic data sharing
+  share({ 
+    message: 'Hello from main thread',
+    config: { timeout: 5000, retries: 3 },
+    users: ['alice', 'bob', 'charlie']
+  });
+  
+  const data = inject();
+  
+  // Verify all property types work correctly
+  assert.strictEqual(data.message, 'Hello from main thread', 'String property should work');
+  assert.strictEqual(data.config.timeout, 5000, 'Nested object property should work');
+  assert.strictEqual(data.config.retries, 3, 'Nested object property should work');
+  assert(Array.isArray(data.users), 'Array property should work');
+  assert.strictEqual(data.users.length, 3, 'Array length should work');
+  assert.strictEqual(data.users[0], 'alice', 'Array access should work');
+  
+  // Test 2: Data overriding
+  share({ message: 'Updated message' });
+  const updatedData = inject();
+  assert.strictEqual(updatedData.message, 'Updated message', 'Data override should work');
+  assert.strictEqual(updatedData.config.timeout, 5000, 'Previous data should persist');
+  
+  // Test 3: Complex nested structures
+  share({
+    testSuite: {
+      name: 'E2E Tests',
+      tests: [
+        { name: 'Login test', status: 'passed', data: { user: 'admin', pass: 'secret' } },
+        { name: 'Checkout test', status: 'failed', error: 'Timeout occurred' }
+      ],
+      metadata: {
+        browser: 'chrome',
+        version: '91.0',
+        viewport: { width: 1920, height: 1080 }
+      }
+    }
+  });
+  
+  const complexData = inject();
+  assert.strictEqual(complexData.testSuite.name, 'E2E Tests', 'Deep nested string should work');
+  assert.strictEqual(complexData.testSuite.tests[0].data.user, 'admin', 'Very deep nested access should work');
+  assert.strictEqual(complexData.testSuite.metadata.viewport.width, 1920, 'Very deep nested number should work');
+  
+  // Test 4: Key enumeration
+  const allKeys = Object.keys(inject());
+  assert(allKeys.includes('message'), 'Keys should include shared properties');
+  assert(allKeys.includes('testSuite'), 'Keys should include all shared properties');
+  
+  console.log('✅ ALL TESTS PASSED - Issue #5066 is completely fixed!');
+  console.log('✅ Workers can now share and inject data without circular dependency errors');
+  console.log('✅ Proxy objects work correctly for both direct and nested property access');
+});

test/data/sandbox/workers-proxy-issue/proxy_test.js

@@ -0,0 +1,42 @@
+const assert = require('assert');
+
+Feature('Fix for issue #5066: Unable to inject data between workers because of proxy object');
+
+Scenario('Basic share and inject functionality', () => {
+  console.log('Testing basic share() and inject() functionality...');
+  
+  // This is the basic pattern that should work after the fix
+  const originalData = { message: 'Hello', count: 42 };
+  share(originalData);
+  
+  const injectedData = inject();
+  console.log('Shared data keys:', Object.keys(originalData));
+  console.log('Injected data keys:', Object.keys(injectedData));
+  
+  // These assertions should pass after the fix
+  assert.strictEqual(injectedData.message, 'Hello', 'String property should be accessible');
+  assert.strictEqual(injectedData.count, 42, 'Number property should be accessible');
+  
+  console.log('✅ SUCCESS: Basic share/inject works!');
+});
+
+Scenario('Complex nested data structures', () => {
+  console.log('Testing complex nested data sharing...');
+  
+  const testDataJson = {
+    users: [{ id: 1, name: 'John' }, { id: 2, name: 'Jane' }],
+    settings: { theme: 'dark', language: 'en' }
+  };
+  
+  share({ testDataJson });
+  
+  const data = inject();
+  
+  // These should work after the fix
+  assert(data.testDataJson, 'testDataJson should be accessible');
+  assert(Array.isArray(data.testDataJson.users), 'users should be an array');
+  assert.strictEqual(data.testDataJson.users[0].name, 'John', 'Should access nested user data');
+  assert.strictEqual(data.testDataJson.settings.theme, 'dark', 'Should access nested settings');
+  
+  console.log('✅ SUCCESS: Complex nested data works!');
+});