fixed screenshot tests

Author: DavertMik

lib/mocha/cli.js

@@ -198,17 +198,25 @@ class Cli extends Base {
         // add new line before the message
         err.message = '\n  ' + err.message
 
+        // explicitly show file with error
+        if (test.file) {
+          log += `\n${output.styles.basic(figures.circle)} ${output.styles.section('File:')} ${output.styles.basic(test.file)}\n`
+        }
+
         const steps = test.steps || (test.ctx && test.ctx.test.steps)
 
         if (steps && steps.length) {
           let scenarioTrace = ''
-          steps.reverse().forEach(step => {
-            const hasFailed = step.status === 'failed'
-            let line = `${hasFailed ? output.styles.bold(figures.cross) : figures.tick} ${step.toCode()} ${step.line()}`
-            if (hasFailed) line = output.styles.bold(line)
-            scenarioTrace += `\n${line}`
-          })
-          log += `${output.styles.basic(figures.circle)} ${output.styles.section('Scenario Steps')}:${scenarioTrace}\n`
+          steps
+            .reverse()
+            .slice(0, 10)
+            .forEach(step => {
+              const hasFailed = step.status === 'failed'
+              let line = `${hasFailed ? output.styles.bold(figures.cross) : figures.tick} ${step.toCode()} ${step.line()}`
+              if (hasFailed) line = output.styles.bold(line)
+              scenarioTrace += `\n${line}`
+            })
+          log += `\n${output.styles.basic(figures.circle)} ${output.styles.section('Scenario Steps')}:${scenarioTrace}\n`
         }
 
         // display artifacts in debug mode

lib/plugin/pageInfo.js

@@ -62,10 +62,7 @@ module.exports = function (config = {}) {
     })
     recorder.add('HTML snapshot failed test', async () => {
       try {
-        const currentOutputLevel = output.level()
-        output.level(0)
         const html = await helper.grabHTMLFrom('body')
-        output.level(currentOutputLevel)
 
         if (!html) return
 

lib/plugin/screenshotOnFail.js

@@ -64,7 +64,7 @@ module.exports = function (config) {
   }
 
   if (Codeceptjs.container.mocha()) {
-    options.reportDir = Codeceptjs.container.mocha().options.reporterOptions && Codeceptjs.container.mocha().options.reporterOptions.reportDir
+    options.reportDir = Codeceptjs.container.mocha()?.options?.reporterOptions && Codeceptjs.container.mocha()?.options?.reporterOptions?.reportDir
   }
 
   if (options.disableScreenshots) {
@@ -73,7 +73,7 @@ module.exports = function (config) {
   }
 
   event.dispatcher.on(event.test.failed, (test, _err, hookName) => {
-    if (hookName == 'BeforeSuite' || hookName == 'AfterSuite') {
+    if (hookName === 'BeforeSuite' || hookName === 'AfterSuite') {
       // no browser here
       return
     }

lib/plugin/stepByStepReport.js

@@ -122,7 +122,7 @@ module.exports = function (config) {
   })
 
   event.dispatcher.on(event.test.failed, (test, _err, hookName) => {
-    if (hookName == 'BeforeSuite' || hookName == 'AfterSuite') {
+    if (hookName === 'BeforeSuite' || hookName === 'AfterSuite') {
       // no browser here
       return
     }

test/unit/plugin/screenshotOnFail_test.js

@@ -49,14 +49,17 @@ describe('screenshotOnFail', () => {
 
   it('should create screenshot with unique name', async () => {
     screenshotOnFail({ uniqueScreenshotNames: true })
-    event.dispatcher.emit(event.test.failed, { title: 'test1', uuid: 1 })
+
+    const test = { title: 'test1', uid: 1 }
+    event.dispatcher.emit(event.test.failed, test)
     await recorder.promise()
     expect(screenshotSaved.called).is.ok
-    expect('test1_1.failed.png').is.equal(screenshotSaved.getCall(0).args[0])
+    expect(`test1_${test.uid}.failed.png`).is.equal(screenshotSaved.getCall(0).args[0])
   })
 
-  it('should create screenshot with unique name when uuid is null', async () => {
+  it('should create screenshot with unique name when uid is null', async () => {
     screenshotOnFail({ uniqueScreenshotNames: true })
+
     event.dispatcher.emit(event.test.failed, { title: 'test1' })
     await recorder.promise()
     expect(screenshotSaved.called).is.ok
@@ -67,14 +70,14 @@ describe('screenshotOnFail', () => {
 
   it('should not save screenshot in BeforeSuite', async () => {
     screenshotOnFail({ uniqueScreenshotNames: true })
-    event.dispatcher.emit(event.test.failed, { title: 'test1', ctx: { _runnable: { title: 'hook: BeforeSuite' } } })
+    event.dispatcher.emit(event.test.failed, { title: 'test1' }, null, 'BeforeSuite')
     await recorder.promise()
     expect(!screenshotSaved.called).is.ok
   })
 
   it('should not save screenshot in AfterSuite', async () => {
     screenshotOnFail({ uniqueScreenshotNames: true })
-    event.dispatcher.emit(event.test.failed, { title: 'test1', ctx: { _runnable: { title: 'hook: AfterSuite' } } })
+    event.dispatcher.emit(event.test.failed, { title: 'test1' }, null, 'AfterSuite')
     await recorder.promise()
     expect(!screenshotSaved.called).is.ok
   })