Fix html hyperlinks

Author: angelina-momin

R/utils_render_reigster_html.r

@@ -71,9 +71,7 @@ create_index_postfix_html <- function(output_dir, filter, register_table_name, i
   # Generating the postfix for non-register table pages (e.g. list of venues and codecheckers)
   else{
     postfix_template <- readLines(CONFIG$TEMPLATE_DIR[["non_reg"]][["postfix"]], warn = FALSE)
-    hrefs <- list(
-      json_href = paste0("https://codecheck.org.uk/register/", filter, "/index.json")
-    )
+    hrefs <- generate_html_postfix_hrefs_non_reg(filter, register_table_name)
   }
 
   output <- whisker.render(postfix_template, hrefs)

R/utils_render_table_non_registers.R

@@ -10,7 +10,7 @@ render_non_register_tables_html <- function(list_reg_tables, page_type){
   # This is needed when the render function returns a single table which is the
   # case when there are not subcategory tables such as the case for codecheckers
   if (is.data.frame(output)){
-    output <- list(page_type = output)
+    output <- setNames(list(output), page_type)
   }
   return(output)  
 }
@@ -192,4 +192,25 @@ generate_html_header <- function(table, page_type, table_name){
   )
 
   return(html_header)
+}
+
+generate_html_postfix_hrefs_non_reg <- function(filter, register_table_name){  
+  
+  # For register tables that arent of subcategories of a filter type, the
+  # json url link is register/filter/index.json
+  if (register_table_name %in% list("all_venues", "codecheckers")){
+    hrefs <- list(
+      json_href = paste0("https://codecheck.org.uk/register/", filter, "/index.json")
+    )
+  }
+
+  # For pages of the filter subcategories, the json url is of form
+  # filter/register_table_name/index.json where register_table_name is the subcategory name
+  else{
+    hrefs <- list(
+      json_href = paste0("https://codecheck.org.uk/register/", filter, "/", register_table_name,"/index.json")
+    )
+  }
+
+  return(hrefs)
 }