Grab Gemfile.lock lines once at top of analysis

Author: dblandin

lib/cc/engine/bundler_audit/analyzer.rb

@@ -13,7 +13,7 @@ def run
           if gemfile_lock_exists?
             Dir.chdir(directory) do
               Bundler::Audit::Scanner.new.scan do |vulnerability|
-                result = Result.new(vulnerability, File.open(gemfile_lock_path))
+                result = Result.new(vulnerability, gemfile_lock_lines)
                 issue = result.to_issue
 
                 io.print("#{issue.to_json}\0")
@@ -28,6 +28,10 @@ def run
 
         attr_reader :directory, :io
 
+        def gemfile_lock_lines
+          @gemfile_lock_lines ||= File.open(gemfile_lock_path).lines.to_a
+        end
+
         def gemfile_lock_exists?
           File.exist?(gemfile_lock_path)
         end

lib/cc/engine/bundler_audit/result.rb

@@ -9,10 +9,10 @@ class Result
           low: "info",
         }.freeze
 
-        def initialize(result, gemfile_lock)
+        def initialize(result, gemfile_lock_lines)
           @gem = result.gem
           @advisory = result.advisory
-          @gemfile_lock = gemfile_lock
+          @gemfile_lock_lines = gemfile_lock_lines
         end
 
         def to_issue
@@ -38,7 +38,7 @@ def to_issue
 
         private
 
-        attr_reader :advisory, :gem, :gemfile_lock
+        attr_reader :advisory, :gem, :gemfile_lock_lines
 
         def content_body
           [
@@ -51,7 +51,7 @@ def content_body
 
         def line_number
           @line_number ||= begin
-             gemfile_lock.find_index do |line|
+             gemfile_lock_lines.find_index do |line|
                (match = GEM_REGEX.match(line)) && match[:name] == gem.name
              end + 1
           end