CC issues

Author: dblandin

.codeclimate.yml

@@ -1,6 +1,9 @@
 engines:
   rubocop:
     enabled: true
+    exclude_fingerprints:
+    # Ignoring long method length for Issue#to_json
+    - 3d618821b1ce28599d6c54f90bb4df59
 ratings:
   paths:
   - "**.rb"

.rubocop.yml

@@ -1,3 +1,5 @@
+AllCops:
+  TargetRubyVersion: 2.2
 Metrics/AbcSize:
   Enabled: false
 
@@ -16,7 +18,7 @@ Style/StringLiterals:
 Style/Documentation:
   Enabled: false
 
-Style/TrailingComma:
+Style/TrailingCommaInLiteral:
   Enabled: false
 
 Style/ClassAndModuleChildren:

lib/cc/engine/bundler_audit/analyzer.rb

@@ -42,4 +42,3 @@ def gemfile_lock_path
     end
   end
 end
-

lib/cc/engine/bundler_audit/issue.rb

@@ -2,11 +2,11 @@ module CC
   module Engine
     module BundlerAudit
       class Issue
-        GEM_REGEX = /^\s*(?<name>\S+) \([\d.]+\)/.freeze
+        GEM_REGEX = /^\s*(?<name>\S+) \([\d.]+\)/
         SEVERITIES = {
           high: "critical",
           medium: "normal",
-          low: "info",
+          low: "info"
         }.freeze
 
         def initialize(result, gemfile_lock_lines)
@@ -17,7 +17,7 @@ def initialize(result, gemfile_lock_lines)
 
         def to_json(*a)
           {
-            categories: ["Security"],
+            categories: %w[Security],
             check_name: "Insecure Dependency",
             content: {
               body: content_body
@@ -32,7 +32,7 @@ def to_json(*a)
             },
             remediation_points: remediation_points,
             severity: severity,
-            type: "Issue",
+            type: "Issue"
           }.to_json(a)
         end
 
@@ -45,15 +45,15 @@ def content_body
             "**Advisory**: #{identifier}",
             "**Criticality**: #{advisory.criticality.capitalize}",
             "**URL**: #{advisory.url}",
-            "**Solution**: #{solution}",
+            "**Solution**: #{solution}"
           ].join("\n\n")
         end
 
         def line_number
           @line_number ||= begin
-             gemfile_lock_lines.find_index do |line|
-               (match = GEM_REGEX.match(line)) && match[:name] == gem.name
-             end + 1
+            gemfile_lock_lines.find_index do |line|
+              (match = GEM_REGEX.match(line)) && match[:name] == gem.name
+            end + 1
           end
         end
 

lib/cc/engine/bundler_audit/remediation.rb

@@ -7,24 +7,14 @@ class Remediation
         PATCH_UPGRADE_POINTS = 500_000
         UNPATCHED_VERSION_POINTS = 500_000_000
 
-
         def initialize(gem_version, patched_versions)
           @gem_version = gem_version
           @patched_versions = patched_versions
         end
 
         def points
           if upgrade_versions.any?
-            upgrade_versions.map do |upgrade_version|
-              case
-              when current_version.major != upgrade_version.major
-                MAJOR_UPGRADE_POINTS
-              when current_version.minor != upgrade_version.minor
-                MINOR_UPGRADE_POINTS
-              when current_version.tiny != upgrade_version.tiny
-                PATCH_UPGRADE_POINTS
-              end
-            end.min
+            upgrade_versions.map { |version| calculate_points(version) }.min
           else
             UNPATCHED_VERSION_POINTS
           end
@@ -34,6 +24,17 @@ def points
 
         attr_reader :gem_version, :patched_versions
 
+        def calculate_points(upgrade_version)
+          case
+          when current_version.major != upgrade_version.major
+            MAJOR_UPGRADE_POINTS
+          when current_version.minor != upgrade_version.minor
+            MINOR_UPGRADE_POINTS
+          when current_version.tiny != upgrade_version.tiny
+            PATCH_UPGRADE_POINTS
+          end
+        end
+
         def current_version
           @current_version ||= Versionomy.parse(gem_version.to_s)
         end