Merge pull request #1 from codeclimate/gd-gemfile-absence

Emit warning when Gemfile.lock does not exist

Author: gdiggs

Gemfile

@@ -3,3 +3,9 @@ source "https://rubygems.org"
 gem 'bundler-audit'
 gem 'json'
 gem 'versionomy'
+gem "rake"
+
+group :test do
+  gem "rspec", require: false
+  gem "fakefs", require: false
+end

Gemfile.lock

@@ -5,7 +5,23 @@ GEM
     bundler-audit (0.3.1)
       bundler (~> 1.2)
       thor (~> 0.18)
+    diff-lcs (1.2.5)
+    fakefs (0.6.7)
     json (1.8.3)
+    rake (10.4.2)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
+    rspec-core (3.3.1)
+      rspec-support (~> 3.3.0)
+    rspec-expectations (3.3.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-mocks (3.3.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-support (3.3.0)
     thor (0.19.1)
     versionomy (0.4.4)
       blockenspiel (>= 0.4.5)
@@ -15,7 +31,10 @@ PLATFORMS
 
 DEPENDENCIES
   bundler-audit
+  fakefs
   json
+  rake
+  rspec
   versionomy
 
 BUNDLED WITH

Rakefile

@@ -0,0 +1,4 @@
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec

lib/cc/engine/bundler_audit.rb

@@ -11,22 +11,34 @@ def initialize(directory: , io: , engine_config: )
       end
 
       def run
-        Dir.chdir(@directory)
-        raw_output = `bundle-audit`
-        raw_issues = raw_output.split(/\n\n/).select { |chunk| 
-          chunk =~ /^Name: /
-        }
-        @gemfile_lock_lines = File.read(
-          File.join(@directory, 'Gemfile.lock')
-        ).lines
-        raw_issues.each do |raw_issue|
-          issue = issue_from_raw(raw_issue)
-          @io.print("#{issue.to_json}\0")
+        if gemfile_lock_exists?
+          Dir.chdir(@directory)
+          raw_output = `bundle-audit`
+          raw_issues = raw_output.split(/\n\n/).select { |chunk|
+            chunk =~ /^Name: /
+          }
+          @gemfile_lock_lines = File.read(
+            File.join(@directory, 'Gemfile.lock')
+          ).lines
+          raw_issues.each do |raw_issue|
+            issue = issue_from_raw(raw_issue)
+            @io.print("#{issue.to_json}\0")
+          end
+        else
+          warning = {
+            type: "warning",
+            description: "No Gemfile.lock file found"
+          }
+          @io.print("#{warning.to_json}\0")
         end
       end
 
       private
 
+      def gemfile_lock_exists?
+        File.exist?(File.join(@directory, 'Gemfile.lock'))
+      end
+
       def issue_from_raw(raw_issue)
         raw_issue_hash = {}
         raw_issue.lines.each do |l|

spec/cc/engine/bundler_audit_spec.rb

@@ -0,0 +1,20 @@
+require "spec_helper"
+
+module CC::Engine
+  describe BundlerAudit do
+    describe "#run" do
+      it "emits a warning when no Gemfile exists" do
+        FakeFS do
+          directory = "/c"
+          FileUtils.mkdir_p(directory)
+          io = StringIO.new
+          config = {}
+
+          BundlerAudit.new(directory: directory, io: io, engine_config: config).run
+
+          expect(io.string).to match(%{{"type":"warning","description":"No Gemfile.lock file found"}})
+        end
+      end
+    end
+  end
+end

spec/spec_helper.rb

@@ -0,0 +1,6 @@
+$LOAD_PATH.unshift(File.expand_path(File.join(File.dirname(__FILE__), "../lib")))
+
+require "rspec"
+require "fakefs/safe"
+
+require "cc/engine/bundler_audit"