Automatically exclude symlinks.

Author: fhwang

bin/eslint.js

@@ -57,10 +57,8 @@ function exclusionBasedFileListBuilder(excludePaths) {
 
     allFiles.forEach(function(file, i, a){
       if(excludePaths.indexOf(file.split("/code/")[1]) < 0) {
-        if(!fs.lstatSync(file).isDirectory()) {
-          var extension = "." + file.split(".").pop();
-
-          if(extensions.indexOf(extension) >= 0) {
+        if(fs.lstatSync(file).isFile()) {
+          if (isFileWithMatchingExtension(file)) {
             analysisFiles.push(file);
           }
         }
@@ -71,11 +69,6 @@ function exclusionBasedFileListBuilder(excludePaths) {
   };
 }
 
-function isFileWithMatchingExtension(file, extensions) {
-  var extension = "." + file.split(".").pop();
-  return (extensions.indexOf(extension) >= 0);
-}
-
 function inclusionBasedFileListBuilder(includePaths) {
   // Uses glob to expand the files and directories in includePaths, filtering
   // down to match the list of desired extensions.
@@ -89,16 +82,15 @@ function inclusionBasedFileListBuilder(includePaths) {
           "/code/" + fileOrDirectory + "/**/**"
         );
         filesInThisDirectory.forEach(function(file, j){
-          if(!fs.lstatSync(file).isDirectory()) {
-            if (isFileWithMatchingExtension(file, extensions)) {
-              analysisFiles.push(file);
-            }
+          if (isFileWithMatchingExtension(file, extensions)) {
+            analysisFiles.push(file);
           }
         });
       } else {
         // if not, check for ending in *.js
-        if (isFileWithMatchingExtension(fileOrDirectory, extensions)) {
-          analysisFiles.push("/code/" + fileOrDirectory);
+        var fullPath = "/code/" + fileOrDirectory
+        if (isFileWithMatchingExtension(fullPath, extensions)) {
+          analysisFiles.push(fullPath);
         }
       }
     });
@@ -107,6 +99,16 @@ function inclusionBasedFileListBuilder(includePaths) {
   };
 }
 
+function isFileWithMatchingExtension(file, extensions) {
+  var stats = fs.lstatSync(file);
+  var extension = "." + file.split(".").pop();
+  return (
+    stats.isFile() &&
+    !stats.isSymbolicLink()
+    && extensions.indexOf(extension) >= 0
+  );
+}
+
 var options = {
   extensions: [".js"], ignore: true, reset: false, useEslintrc: true
 };