Update rubocop to 1.31.0 (#318)

- General bundle update.
- Update the docs too.
- Update Ruby to the latest 2.7.x version.
- Add a gemset to improve local development.

Author: BrianHawley

.ruby-gemset

@@ -0,0 +1 @@
+codeclimate-rubocop

.ruby-version

@@ -1 +1 @@
-2.7.2
+2.7.6

Gemfile

@@ -6,7 +6,7 @@ gem "activesupport", require: false
 gem "mry", require: false
 gem "parser"
 gem "pry", require: false
-gem "rubocop", "1.30.1", require: false
+gem "rubocop", "1.31.0", require: false
 gem "rubocop-i18n", require: false
 gem "rubocop-graphql", require: false
 gem "rubocop-minitest", require: false

Gemfile.lock

@@ -13,7 +13,7 @@ GEM
     i18n (1.10.0)
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
-    minitest (5.15.0)
+    minitest (5.16.1)
     mry (0.78.0.0)
       rubocop (>= 0.41.0)
     parallel (1.22.1)
@@ -40,7 +40,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
-    rubocop (1.30.1)
+    rubocop (1.31.0)
       parallel (~> 1.10)
       parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
@@ -51,36 +51,36 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.18.0)
       parser (>= 3.1.1.0)
-    rubocop-graphql (0.14.3)
+    rubocop-graphql (0.14.4)
       rubocop (>= 0.87, < 2)
     rubocop-i18n (3.0.0)
       rubocop (~> 1.0)
-    rubocop-minitest (0.20.0)
+    rubocop-minitest (0.20.1)
       rubocop (>= 0.90, < 2.0)
-    rubocop-performance (1.14.1)
+    rubocop-performance (1.14.2)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.14.2)
+    rubocop-rails (2.15.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
     rubocop-rspec (2.11.1)
       rubocop (~> 1.19)
-    rubocop-sequel (0.3.3)
+    rubocop-sequel (0.3.4)
       rubocop (~> 1.0)
-    rubocop-shopify (2.7.0)
+    rubocop-shopify (2.7.1)
       rubocop (~> 1.30)
-    rubocop-sorbet (0.6.8)
+    rubocop-sorbet (0.6.10)
       rubocop (>= 0.90.0)
     rubocop-thread_safety (0.4.4)
       rubocop (>= 0.53.0)
     ruby-progressbar (1.11.0)
     test-prof (1.0.9)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.1.0)
+    unicode-display_width (2.2.0)
 
 PLATFORMS
   ruby
@@ -92,7 +92,7 @@ DEPENDENCIES
   pry
   rake
   rspec
-  rubocop (= 1.30.1)
+  rubocop (= 1.31.0)
   rubocop-graphql
   rubocop-i18n
   rubocop-minitest

config/contents/gemspec/deprecated_attribute_assignment.md

@@ -1,5 +1,5 @@
 Checks that deprecated attribute attributes are not set in a gemspec file.
-Removing `test_files` allows the user to receive smaller packed gems.
+Removing deprecated attributes allows the user to receive smaller packed gems.
 
 ### Example:
 

config/contents/layout/first_hash_element_indentation.md

@@ -27,6 +27,14 @@ styles are 'consistent' and 'align_braces'. Here are examples:
     and_in_a_method_call({
       no: :difference
                          })
+    takes_multi_pairs_hash(x: {
+      a: 1,
+      b: 2
+    },
+                           y: {
+                             c: 1,
+                             d: 2
+                           })
 
     # good
     special_inside_parentheses
@@ -36,6 +44,14 @@ styles are 'consistent' and 'align_braces'. Here are examples:
     but_in_a_method_call({
                            its_like: :this
                          })
+    takes_multi_pairs_hash(x: {
+                             a: 1,
+                             b: 2
+                           },
+                           y: {
+                             c: 1,
+                             d: 2
+                           })
 
 ### Example: EnforcedStyle: consistent
     # The `consistent` style enforces that the first key in a hash
@@ -59,6 +75,7 @@ styles are 'consistent' and 'align_braces'. Here are examples:
       no: :difference
     })
 
+
 ### Example: EnforcedStyle: align_braces
     # The `align_brackets` style enforces that the opening and closing
     # braces are indented to the same position.
@@ -67,8 +84,24 @@ styles are 'consistent' and 'align_braces'. Here are examples:
     and_now_for_something = {
                               completely: :different
     }
+    takes_multi_pairs_hash(x: {
+      a: 1,
+      b: 2
+    },
+                            y: {
+                                 c: 1,
+                                 d: 2
+                               })
 
     # good
     and_now_for_something = {
                               completely: :different
-                            }
+                            }
+    takes_multi_pairs_hash(x: {
+                                a: 1,
+                                b: 2
+                              },
+                           y: {
+                                c: 1,
+                                d: 2
+                              })

config/contents/layout/line_continuation_leading_space.md

@@ -0,0 +1,19 @@
+Checks that strings broken over multiple lines (by a backslash) contain
+trailing spaces instead of leading spaces.
+
+### Example:
+    # bad
+    'this text contains a lot of' \
+    '               spaces'
+
+    # good
+    'this text contains a lot of               ' \
+    'spaces'
+
+    # bad
+    'this text is too' \
+    ' long'
+
+    # good
+    'this text is too ' \
+    'long'

config/contents/layout/line_continuation_spacing.md

@@ -0,0 +1,24 @@
+Checks that the backslash of a line continuation is separated from
+preceding text by exactly one space (default) or zero spaces.
+
+### Example: EnforcedStyle: space (default)
+    # bad
+    'a'\
+    'b'  \
+    'c'
+
+    # good
+    'a' \
+    'b' \
+    'c'
+
+### Example: EnforcedStyle: no_space
+    # bad
+    'a' \
+    'b'  \
+    'c'
+
+    # good
+    'a'\
+    'b'\
+    'c'

config/contents/lint/constant_overwritten_in_rescue.md

@@ -0,0 +1,19 @@
+Checks for overwriting an exception with an exception result by use `rescue =>`.
+
+You intended to write as `rescue StandardError`.
+However, you have written `rescue => StandardError`.
+In that case, the result of `rescue` will overwrite `StandardError`.
+
+### Example:
+
+    # bad
+    begin
+      something
+    rescue => StandardError
+    end
+
+    # good
+    begin
+      something
+    rescue StandardError
+    end

config/contents/lint/non_atomic_file_operation.md

@@ -0,0 +1,36 @@
+Checks for non-atomic file operation.
+And then replace it with a nearly equivalent and atomic method.
+
+These can cause problems that are difficult to reproduce,
+especially in cases of frequent file operations in parallel,
+such as test runs with parallel_rspec.
+
+For examples: creating a directory if there is none, has the following problems
+
+An exception occurs when the directory didn't exist at the time of `exist?`,
+but someone else created it before `mkdir` was executed.
+
+Subsequent processes are executed without the directory that should be there
+when the directory existed at the time of `exist?`,
+but someone else deleted it shortly afterwards.
+
+### Safety:
+
+This cop is unsafe, because autocorrection change to atomic processing.
+The atomic processing of the replacement destination is not guaranteed
+to be strictly equivalent to that before the replacement.
+
+### Example:
+    # bad
+    unless FileTest.exist?(path)
+      FileUtils.makedirs(path)
+    end
+
+    if FileTest.exist?(path)
+      FileUtils.remove(path)
+    end
+
+    # good
+    FileUtils.mkdir_p(path)
+
+    FileUtils.rm_rf(path)