Update rubocop to 1.30.1 (#317)

- General bundle update.
- Update the docs too.

Author: BrianHawley

Gemfile

@@ -6,7 +6,7 @@ gem "activesupport", require: false
 gem "mry", require: false
 gem "parser"
 gem "pry", require: false
-gem "rubocop", "1.30.0", require: false
+gem "rubocop", "1.30.1", require: false
 gem "rubocop-i18n", require: false
 gem "rubocop-graphql", require: false
 gem "rubocop-minitest", require: false

Gemfile.lock

@@ -40,7 +40,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
-    rubocop (1.30.0)
+    rubocop (1.30.1)
       parallel (~> 1.10)
       parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
@@ -57,7 +57,7 @@ GEM
       rubocop (~> 1.0)
     rubocop-minitest (0.20.0)
       rubocop (>= 0.90, < 2.0)
-    rubocop-performance (1.14.0)
+    rubocop-performance (1.14.1)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rails (2.14.2)
@@ -93,7 +93,7 @@ DEPENDENCIES
   pry
   rake
   rspec
-  rubocop (= 1.30.0)
+  rubocop (= 1.30.1)
   rubocop-graphql
   rubocop-i18n
   rubocop-minitest

config/contents/layout/empty_lines_around_block_body.md

@@ -1,18 +1,18 @@
 Checks if empty lines around the bodies of blocks match
 the configuration.
 
-### Example: EnforcedStyle: empty_lines
+### Example: EnforcedStyle: no_empty_lines (default)
     # good
 
     foo do |bar|
-
       # ...
-
     end
 
-### Example: EnforcedStyle: no_empty_lines (default)
+### Example: EnforcedStyle: empty_lines
     # good
 
     foo do |bar|
+
       # ...
+
     end

config/contents/layout/empty_lines_around_class_body.md

@@ -1,6 +1,15 @@
 Checks if empty lines around the bodies of classes match
 the configuration.
 
+### Example: EnforcedStyle: no_empty_lines (default)
+    # good
+
+    class Foo
+      def bar
+        # ...
+      end
+    end
+
 ### Example: EnforcedStyle: empty_lines
     # good
 
@@ -49,13 +58,4 @@ the configuration.
         # ...
       end
 
-    end
-
-### Example: EnforcedStyle: no_empty_lines (default)
-    # good
-
-    class Foo
-      def bar
-        # ...
-      end
     end

config/contents/layout/empty_lines_around_module_body.md

@@ -1,6 +1,15 @@
 Checks if empty lines around the bodies of modules match
 the configuration.
 
+### Example: EnforcedStyle: no_empty_lines (default)
+    # good
+
+    module Foo
+      def bar
+        # ...
+      end
+    end
+
 ### Example: EnforcedStyle: empty_lines
     # good
 
@@ -29,13 +38,4 @@ the configuration.
 
       def bar; end
 
-    end
-
-### Example: EnforcedStyle: no_empty_lines (default)
-    # good
-
-    module Foo
-      def bar
-        # ...
-      end
     end

config/contents/layout/first_argument_indentation.md

@@ -32,9 +32,10 @@ This cop will respect `Layout/ArgumentAlignment` and will not work when
     nested_first_param),
     second_param
 
-### Example: EnforcedStyle: consistent
-    # The first argument should always be indented one step more than the
-    # preceding line.
+### Example: EnforcedStyle: special_for_inner_method_call_in_parentheses (default)
+    # Same as `special_for_inner_method_call` except that the special rule
+    # only applies if the outer method call encloses its arguments in
+    # parentheses.
 
     # good
     some_method(
@@ -46,7 +47,7 @@ This cop will respect `Layout/ArgumentAlignment` and will not work when
     second_param)
 
     foo = some_method(nested_call(
-      nested_first_param),
+                        nested_first_param),
     second_param)
 
     foo = some_method(
@@ -58,64 +59,63 @@ This cop will respect `Layout/ArgumentAlignment` and will not work when
       nested_first_param),
     second_param
 
-### Example: EnforcedStyle: consistent_relative_to_receiver
-    # The first argument should always be indented one level relative to
-    # the parent that is receiving the argument
+### Example: EnforcedStyle: consistent
+    # The first argument should always be indented one step more than the
+    # preceding line.
 
     # good
     some_method(
       first_param,
     second_param)
 
     foo = some_method(
-            first_param,
+      first_param,
     second_param)
 
     foo = some_method(nested_call(
-                        nested_first_param),
+      nested_first_param),
     second_param)
 
     foo = some_method(
-            nested_call(
-              nested_first_param),
+      nested_call(
+        nested_first_param),
     second_param)
 
     some_method nested_call(
-                  nested_first_param),
-    second_params
+      nested_first_param),
+    second_param
 
-### Example: EnforcedStyle: special_for_inner_method_call
-    # The first argument should normally be indented one step more than
-    # the preceding line, but if it's a argument for a method call that
-    # is itself a argument in a method call, then the inner argument
-    # should be indented relative to the inner method.
+### Example: EnforcedStyle: consistent_relative_to_receiver
+    # The first argument should always be indented one level relative to
+    # the parent that is receiving the argument
 
     # good
     some_method(
       first_param,
     second_param)
 
     foo = some_method(
-      first_param,
+            first_param,
     second_param)
 
     foo = some_method(nested_call(
                         nested_first_param),
     second_param)
 
     foo = some_method(
-      nested_call(
-        nested_first_param),
+            nested_call(
+              nested_first_param),
     second_param)
 
     some_method nested_call(
                   nested_first_param),
-    second_param
+    second_params
 
-### Example: EnforcedStyle: special_for_inner_method_call_in_parentheses (default)
-    # Same as `special_for_inner_method_call` except that the special rule
-    # only applies if the outer method call encloses its arguments in
-    # parentheses.
+### Example: EnforcedStyle: special_for_inner_method_call
+    # The first argument should normally be indented one step more than
+    # the preceding line, but if it's a argument for a method call that
+    # is itself a argument in a method call, then the inner argument
+    # should be indented relative to the inner method.
 
     # good
     some_method(
@@ -136,5 +136,5 @@ This cop will respect `Layout/ArgumentAlignment` and will not work when
     second_param)
 
     some_method nested_call(
-      nested_first_param),
+                  nested_first_param),
     second_param

config/contents/layout/space_inside_array_literal_brackets.md

@@ -1,16 +1,6 @@
 Checks that brackets used for array literals have or don't have
 surrounding space depending on configuration.
 
-### Example: EnforcedStyle: space
-    # The `space` style enforces that array literals have
-    # surrounding space.
-
-    # bad
-    array = [a, b, c, d]
-
-    # good
-    array = [ a, b, c, d ]
-
 ### Example: EnforcedStyle: no_space (default)
     # The `no_space` style enforces that array literals have
     # no surrounding space.
@@ -21,6 +11,16 @@ surrounding space depending on configuration.
     # good
     array = [a, b, c, d]
 
+### Example: EnforcedStyle: space
+    # The `space` style enforces that array literals have
+    # surrounding space.
+
+    # bad
+    array = [a, b, c, d]
+
+    # good
+    array = [ a, b, c, d ]
+
 ### Example: EnforcedStyle: compact
     # The `compact` style normally requires a space inside
     # array brackets, with the exception that successive left

config/contents/layout/trailing_empty_lines.md

@@ -1,33 +1,33 @@
 Looks for trailing blank lines and a final newline in the
 source code.
 
-### Example: EnforcedStyle: final_blank_line
-    # `final_blank_line` looks for one blank line followed by a new line
-    # at the end of files.
+### Example: EnforcedStyle: final_newline (default)
+    # `final_newline` looks for one newline at the end of files.
 
     # bad
     class Foo; end
+
     # EOF
 
     # bad
     class Foo; end # EOF
 
     # good
     class Foo; end
-
     # EOF
 
-### Example: EnforcedStyle: final_newline (default)
-    # `final_newline` looks for one newline at the end of files.
+### Example: EnforcedStyle: final_blank_line
+    # `final_blank_line` looks for one blank line followed by a new line
+    # at the end of files.
 
     # bad
     class Foo; end
-
     # EOF
 
     # bad
     class Foo; end # EOF
 
     # good
     class Foo; end
+
     # EOF

config/contents/naming/variable_number.md

@@ -6,23 +6,6 @@ Additionally, `CheckMethodNames` and `CheckSymbols` configuration options
 can be used to specify whether method names and symbols should be checked.
 Both are enabled by default.
 
-### Example: EnforcedStyle: snake_case
-    # bad
-    :some_sym1
-    variable1 = 1
-
-    def some_method1; end
-
-    def some_method_1(arg1); end
-
-    # good
-    :some_sym_1
-    variable_1 = 1
-
-    def some_method_1; end
-
-    def some_method_1(arg_1); end
-
 ### Example: EnforcedStyle: normalcase (default)
     # bad
     :some_sym_1
@@ -40,6 +23,23 @@ Both are enabled by default.
 
     def some_method1(arg1); end
 
+### Example: EnforcedStyle: snake_case
+    # bad
+    :some_sym1
+    variable1 = 1
+
+    def some_method1; end
+
+    def some_method_1(arg1); end
+
+    # good
+    :some_sym_1
+    variable_1 = 1
+
+    def some_method_1; end
+
+    def some_method_1(arg_1); end
+
 ### Example: EnforcedStyle: non_integer
     # bad
     :some_sym1