Updated channel and documentation to Rubocop v1.7.0 (#267)

Bumps the 'rubocop' dependency to v1.70.0 as well as some subdependencies, updates the scraped documentation, and fixes several specs. See #267 for additional details.

Author: DanielWright

Gemfile

@@ -6,16 +6,15 @@ gem "activesupport", require: false
 gem "mry", require: false
 gem "parser"
 gem "pry", require: false
-gem "rubocop", "0.92.0", require: false
+gem "rubocop", "1.7.0", require: false
 gem "rubocop-i18n", require: false
-gem "rubocop-migrations", require: false
 gem "rubocop-minitest", require: false
 gem "rubocop-performance", require: false
 gem "rubocop-rails", require: false
 gem "rubocop-rake", require: false
 gem "rubocop-rspec", require: false
 gem "rubocop-sequel", require: false
-gem 'rubocop-sorbet', require: false
+gem "rubocop-sorbet", require: false
 gem "rubocop-thread_safety", require: false
 gem "safe_yaml"
 gem "test-prof", require: false

Gemfile.lock

@@ -17,16 +17,16 @@ GEM
     minitest (5.14.1)
     mry (0.78.0.0)
       rubocop (>= 0.41.0)
-    parallel (1.19.2)
-    parser (2.7.1.5)
+    parallel (1.20.1)
+    parser (3.0.0.0)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rack (2.2.3)
     rainbow (3.0.0)
     rake (13.0.1)
-    regexp_parser (1.8.1)
+    regexp_parser (2.0.3)
     rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
@@ -41,21 +41,19 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (0.92.0)
+    rubocop (1.7.0)
       parallel (~> 1.10)
       parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 0.5.0)
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.7.1)
+    rubocop-ast (1.4.0)
       parser (>= 2.7.1.5)
-    rubocop-i18n (2.0.2)
-      rubocop (~> 0.51)
-    rubocop-migrations (0.1.2)
-      rubocop (~> 0.41)
+    rubocop-i18n (3.0.0)
+      rubocop (~> 1.0)
     rubocop-minitest (0.9.0)
       rubocop (>= 0.74)
     rubocop-performance (1.7.0)
@@ -68,13 +66,13 @@ GEM
       rubocop
     rubocop-rspec (1.41.0)
       rubocop (>= 0.68.1)
-    rubocop-sequel (0.0.6)
-      rubocop (~> 0.55, >= 0.55)
+    rubocop-sequel (0.1.0)
+      rubocop (~> 1.0)
     rubocop-sorbet (0.5.1)
       rubocop
     rubocop-thread_safety (0.4.1)
       rubocop (>= 0.51.0)
-    ruby-progressbar (1.10.1)
+    ruby-progressbar (1.11.0)
     safe_yaml (1.0.5)
     test-prof (0.11.3)
     thread_safe (0.3.6)
@@ -93,9 +91,8 @@ DEPENDENCIES
   pry
   rake
   rspec
-  rubocop (= 0.92.0)
+  rubocop (= 1.7.0)
   rubocop-i18n
-  rubocop-migrations
   rubocop-minitest
   rubocop-performance
   rubocop-rails

config/contents/bundler/duplicated_gem.md

@@ -19,4 +19,13 @@ A Gem's requirements should be listed only once in a Gemfile.
     end
 
     # good
-    gem 'rubocop', groups: [:development, :test]
+    gem 'rubocop', groups: [:development, :test]
+
+    # good - conditional declaration
+    if Dir.exist?(local)
+      gem 'rubocop', path: local
+    elsif ENV['RUBOCOP_VERSION'] == 'master'
+      gem 'rubocop', git: 'https://github.com/rubocop-hq/rubocop.git'
+    else
+      gem 'rubocop', '~> 0.90.0'
+    end

config/contents/gemspec/required_ruby_version.md

@@ -31,12 +31,13 @@ required by gemspec.
       spec.required_ruby_version = '>= 2.5'
     end
 
-    # good
+    # accepted but not recommended
     Gem::Specification.new do |spec|
       spec.required_ruby_version = ['>= 2.5.0', '< 2.7.0']
     end
 
-    # good
+    # accepted but not recommended, since
+    # Ruby does not really follow semantic versionning
     Gem::Specification.new do |spec|
       spec.required_ruby_version = '~> 2.5'
     end

config/contents/layout/else_alignment.md

@@ -1,5 +1,5 @@
 This cop checks the alignment of else keywords. Normally they should
-be aligned with an if/unless/while/until/begin/def keyword, but there
+be aligned with an if/unless/while/until/begin/def/rescue keyword, but there
 are special cases when they should follow the same rules as the
 alignment of end.
 

config/contents/layout/empty_line_between_defs.md

@@ -1,14 +1,15 @@
-This cop checks whether method definitions are
-separated by one empty line.
+This cop checks whether class/module/method definitions are
+separated by one or more empty lines.
 
 `NumberOfEmptyLines` can be an integer (default is 1) or
 an array (e.g. [1, 2]) to specify a minimum and maximum
 number of empty lines permitted.
 
 `AllowAdjacentOneLineDefs` configures whether adjacent
-one-line method definitions are considered an offense.
+one-line definitions are considered an offense.
 
-### Example:
+### Example: EmptyLineBetweenMethodDefs: true (default)
+    # checks for empty lines between method definitions.
 
     # bad
     def a
@@ -23,4 +24,57 @@ one-line method definitions are considered an offense.
     end
 
     def b
-    end
+    end
+
+### Example: EmptyLineBetweenClassDefs: true (default)
+    # checks for empty lines between class definitions.
+
+    # bad
+    class A
+    end
+    class B
+    end
+    def b
+    end
+
+### Example:
+
+    # good
+    class A
+    end
+
+    class B
+    end
+
+    def b
+    end
+
+### Example: EmptyLineBetweenModuleDefs: true (default)
+    # checks for empty lines between module definitions.
+
+    # bad
+    module A
+    end
+    module B
+    end
+    def b
+    end
+
+### Example:
+
+    # good
+    module A
+    end
+
+    module B
+    end
+
+    def b
+    end
+
+### Example: AllowAdjacentOneLineDefs: true
+
+    # good
+    class ErrorA < BaseError; end
+    class ErrorB < BaseError; end
+    class ErrorC < BaseError; end

config/contents/layout/space_around_operators.md

@@ -1,5 +1,7 @@
 Checks that operators have space around them, except for ** which
 should or shouldn't have surrounding space depending on configuration.
+It allows vertical alignment consisting of one or more whitespace
+around operators.
 
 This cop has `AllowForAlignment` option. When `true`, allows most
 uses of extra spacing if the intent is to align with an operator on

config/contents/layout/space_before_brackets.md

@@ -0,0 +1,14 @@
+Checks for space between the name of a receiver and a left
+brackets.
+
+This cop is marked as unsafe because it can occur false positives
+for `do_something [this_is_an_array_literal_argument]` that take
+an array without parentheses as an argument.
+
+### Example:
+
+    # bad
+    collection [index_or_key]
+
+    # good
+    collection[index_or_key]

config/contents/layout/space_inside_parens.md

@@ -6,10 +6,12 @@ Checks for spaces inside ordinary round parentheses.
     # bad
     f( 3)
     g = (a + 3 )
+    f( )
 
     # good
     f(3)
     g = (a + 3)
+    f()
 
 ### Example: EnforcedStyle: space
     # The `space` style enforces that parentheses have a space at the

config/contents/layout/trailing_whitespace.md

@@ -9,14 +9,25 @@ This cop looks for trailing whitespace in the source code.
     # good
     x = 0
 
-### Example: AllowInHeredoc: false
+### Example: AllowInHeredoc: false (default)
     # The line in this example contains spaces after the 0.
     # bad
     code = <<~RUBY
       x = 0
     RUBY
 
-### Example: AllowInHeredoc: true (default)
+    # ok
+    code = <<~RUBY
+      x = 0 #{}
+    RUBY
+
+    # good
+    trailing_whitespace = ' '
+    code = <<~RUBY
+      x = 0#{trailing_whitespace}
+    RUBY
+
+### Example: AllowInHeredoc: true
     # The line in this example contains spaces after the 0.
     # good
     code = <<~RUBY