Updated channel and documentation to Rubocop v0.92.0 (#257)

Bumps the 'rubocop' dependency to v0.92.0, updates the scraped documentation, and fixes the config-upgrader spec by adding the new cops to the config-upgrader fixture.

Author: DanielWright

Gemfile

@@ -6,7 +6,7 @@ gem "activesupport", require: false
 gem "mry", require: false
 gem "parser"
 gem "pry", require: false
-gem "rubocop", "0.90.0", require: false
+gem "rubocop", "0.92.0", require: false
 gem "rubocop-i18n", require: false
 gem "rubocop-migrations", require: false
 gem "rubocop-minitest", require: false

Gemfile.lock

@@ -18,15 +18,15 @@ GEM
     mry (0.78.0.0)
       rubocop (>= 0.41.0)
     parallel (1.19.2)
-    parser (2.7.1.4)
+    parser (2.7.1.5)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rack (2.2.3)
     rainbow (3.0.0)
     rake (13.0.1)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.1)
     rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
@@ -41,17 +41,17 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (0.90.0)
+    rubocop (0.92.0)
       parallel (~> 1.10)
-      parser (>= 2.7.1.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.7)
       rexml
-      rubocop-ast (>= 0.3.0, < 1.0)
+      rubocop-ast (>= 0.5.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.3.0)
-      parser (>= 2.7.1.4)
+    rubocop-ast (0.7.1)
+      parser (>= 2.7.1.5)
     rubocop-i18n (2.0.2)
       rubocop (~> 0.51)
     rubocop-migrations (0.1.2)
@@ -91,7 +91,7 @@ DEPENDENCIES
   pry
   rake
   rspec
-  rubocop (= 0.90.0)
+  rubocop (= 0.92.0)
   rubocop-i18n
   rubocop-migrations
   rubocop-minitest

config/contents/layout/begin_end_alignment.md

@@ -0,0 +1,34 @@
+This cop checks whether the end keyword of `begin` is aligned properly.
+
+Two modes are supported through the `EnforcedStyleAlignWith` configuration
+parameter. If it's set to `start_of_line` (which is the default), the
+`end` shall be aligned with the start of the line where the `begin`
+keyword is. If it's set to `begin`, the `end` shall be aligned with the
+`begin` keyword.
+
+`Layout/EndAlignment` cop aligns with keywords (e.g. `if`, `while`, `case`)
+by default. On the other hand, `||= begin` that this cop targets tends to
+align with the start of the line, it defaults to `EnforcedStyleAlignWith: start_of_line`.
+These style can be configured by each cop.
+
+### Example: EnforcedStyleAlignWith: start_of_line (default)
+    # bad
+    foo ||= begin
+              do_something
+            end
+
+    # good
+    foo ||= begin
+      do_something
+    end
+
+### Example: EnforcedStyleAlignWith: begin
+    # bad
+    foo ||= begin
+      do_something
+    end
+
+    # good
+    foo ||= begin
+              do_something
+            end

config/contents/layout/end_alignment.md

@@ -12,6 +12,11 @@ left-hand-side of the variable assignment, if there is one.
 If it's set to `start_of_line`, the `end` shall be aligned with the
 start of the line where the matching keyword appears.
 
+This `Layout/EndAlignment` cop aligns with keywords (e.g. `if`, `while`, `case`)
+by default. On the other hand, `Layout/BeginEndAlignment` cop aligns with
+`EnforcedStyleAlignWith: start_of_line` by default due to `||= begin` tends
+to align with the start of the line. These style can be configured by each cop.
+
 ### Example: EnforcedStyleAlignWith: keyword (default)
     # bad
 

config/contents/lint/constant_definition_in_block.md

@@ -0,0 +1,46 @@
+Do not define constants within a block, since the block's scope does not
+isolate or namespace the constant in any way.
+
+If you are trying to define that constant once, define it outside of
+the block instead, or use a variable or method if defining the constant
+in the outer scope would be problematic.
+
+For meta-programming, use `const_set`.
+
+### Example:
+    # bad
+    task :lint do
+      FILES_TO_LINT = Dir['lib/*.rb']
+    end
+
+    # bad
+    describe 'making a request' do
+      class TestRequest; end
+    end
+
+    # bad
+    module M
+      extend ActiveSupport::Concern
+      included do
+        LIST = []
+      end
+    end
+
+    # good
+    task :lint do
+      files_to_lint = Dir['lib/*.rb']
+    end
+
+    # good
+    describe 'making a request' do
+      let(:test_request) { Class.new }
+      # see also `stub_const` for RSpec
+    end
+
+    # good
+    module M
+      extend ActiveSupport::Concern
+      included do
+        const_set(:LIST, [])
+      end
+    end

config/contents/lint/duplicate_require.md

@@ -9,3 +9,7 @@ This cop checks for duplicate `require`s and `require_relative`s.
     # good
     require 'foo'
     require 'bar'
+
+    # good
+    require 'foo'
+    require_relative 'foo'

config/contents/lint/identity_comparison.md

@@ -0,0 +1,12 @@
+
+Prefer `equal?` over `==` when comparing `object_id`.
+
+`Object#equal?` is provided to compare objects for identity, and in contrast
+`Object#==` is provided for the purpose of doing value comparison.
+
+### Example:
+    # bad
+    foo.object_id == bar.object_id
+
+    # good
+    foo.equal?(bar)

config/contents/lint/to_json.md

@@ -4,10 +4,21 @@ generation via `JSON.generate(your_obj)`.  Since `JSON#generate` allows
 for an optional argument, your method should too.
 
 ### Example:
-    # bad
-    def to_json
-    end
+    class Point
+      attr_reader :x, :y
+
+      # bad, incorrect arity
+      def to_json
+        JSON.generate([x, y])
+      end
+
+      # good, preserving args
+      def to_json(*args)
+        JSON.generate([x, y], *args)
+      end
 
-    # good
-    def to_json(*_args)
+      # good, discarding args
+      def to_json(*_args)
+        JSON.generate([x, y])
+      end
     end

config/contents/lint/useless_method_definition.md

@@ -7,30 +7,24 @@ an empty constructor just overrides the parent constructor, which is bad anyway.
 ### Example:
     # bad
     def initialize
+      super
     end
 
     def method
       super
     end
 
-    # good
-    def initialize
-      initialize_internals
-    end
-
-    def method
+    # good - with default arguments
+    def initialize(x = Object.new)
       super
-      do_something_else
     end
 
-### Example: AllowComments: true (default)
     # good
     def initialize
-      # Comment.
+      super
+      initialize_internals
     end
 
-### Example: AllowComments: false
-    # bad
-    def initialize
-      # Comment.
+    def method(*args)
+      super(:extra_arg, *args)
     end

config/contents/lint/useless_times.md

@@ -0,0 +1,17 @@
+This cop checks for uses of `Integer#times` that will never yield
+(when the integer <= 0) or that will only ever yield once
+(`1.times`).
+
+This cop is marked as unsafe as `times` returns its receiver, which
+is *usually* OK, but might change behavior.
+
+### Example:
+    # bad
+    -5.times { do_something }
+    0.times { do_something }
+    1.times { do_something  }
+    1.times { |i| do_something(i) }
+
+    # good
+    do_something
+    do_something(1)