Support failure statuses for GitHub

Author: brynary

lib/cc/services/github_pull_requests.rb

@@ -44,7 +44,7 @@ def receive_pull_request
     setup_http
     state = @payload["state"]
 
-    if %w(pending success skipped error).include?(state)
+    if %w[pending success failure skipped error].include?(state)
       send("update_status_#{state}")
     else
       @response = simple_failure("Unknown state")
@@ -75,6 +75,11 @@ def update_status_success
     update_status("success", presenter.success_message)
   end
 
+  def update_status_failure
+    add_comment
+    update_status("failure", presenter.success_message)
+  end
+
   def presenter
     CC::Service::GitHubPullRequestsPresenter.new(@payload)
   end

test/github_pull_requests_test.rb

@@ -30,6 +30,22 @@ def test_pull_request_status_success_detailed
     )
   end
 
+  def test_pull_request_status_failure
+    expect_status_update("pbrisbin/foo", "abc123", {
+      "state"       => "failure",
+      "description" => "Code Climate found 2 new issues and 1 fixed issue.",
+    })
+
+    receive_pull_request(
+      { update_status: true },
+      {
+        github_slug: "pbrisbin/foo",
+        commit_sha:  "abc123",
+        state:       "failure"
+      }
+    )
+  end
+
   def test_pull_request_status_success_generic
     expect_status_update("pbrisbin/foo", "abc123", {
       "state"       => "success",