More robust test for GitHub Pull Request tokens

Author: noahd1

lib/cc/service/response_check.rb

@@ -1,9 +1,10 @@
 class CC::Service
   class HTTPError < StandardError
-    attr_reader :response_body
+    attr_reader :response_body, :status
 
     def initialize(message, env)
       @response_body = env[:body]
+      @status        = env[:status]
 
       super(message)
     end

lib/cc/services/github_pull_requests.rb

@@ -26,9 +26,14 @@ class Config < CC::Service::Config
   def receive_test
     setup_http
 
-    http_get("#{BASE_URL}")
+    http_post(base_status_url("0" * 40))
 
-    { ok: true, message: "OAuth token is valid" }
+  rescue HTTPError => ex
+    if ex.status == 422
+      { ok: true, message: "OAuth token is valid" }
+    else ex.status == 401
+      { ok: false, message: ex.message }
+    end
   rescue => ex
     { ok: false, message: ex.message }
   end
@@ -84,6 +89,10 @@ def setup_http
   end
 
   def status_url
+    base_status_url(commit_sha)
+  end
+
+  def base_status_url(commit_sha)
     "#{BASE_URL}/repos/#{github_slug}/statuses/#{commit_sha}"
   end
 

test/github_pull_requests_test.rb

@@ -27,6 +27,18 @@ def test_pull_request_status_success
     })
   end
 
+  def test_pull_request_test_success
+    @stubs.post("/repos/pbrisbin/foo/statuses/#{"0" * 40}") { |env| [422, {}, ""] }
+
+    assert receive_test({}, { github_slug: "pbrisbin/foo" })[:ok], "Expected test of pull request to be true"
+  end
+
+  def test_pull_request_test_failure
+    @stubs.post("/repos/pbrisbin/foo/statuses/#{"0" * 40}") { |env| [401, {}, ""] }
+
+    assert !receive_test({}, { github_slug: "pbrisbin/foo" })[:ok], "Expected failed test of pull request"
+  end
+
   def test_pull_request_comment
     stub_existing_comments("pbrisbin/foo", 1, %w[Hey Yo])
 
@@ -92,4 +104,12 @@ def receive_pull_request(config, event_data)
     )
   end
 
+  def receive_test(config, event_data)
+    receive(
+      CC::Service::GitHubPullRequests,
+      { oauth_token: "123" }.merge(config),
+      { name: "test" }.merge(event_data)
+    )
+  end
+
 end