PR service: nested hash structure for issue counts

https://trello.com/c/f17uUGRd

Author: Ian C. Anderson

lib/cc/services/github_pull_requests_presenter.rb

@@ -1,7 +1,11 @@
 class CC::Service::GitHubPullRequests::Presenter
   def initialize(payload)
-    @fixed_count = payload["fixed_issue_count"]
-    @new_count = payload["new_issue_count"]
+    issue_comparison_counts = payload["issue_comparison_counts"]
+
+    if issue_comparison_counts
+      @fixed_count = issue_comparison_counts["fixed"]
+      @new_count = issue_comparison_counts["new"]
+    end
   end
 
   def success_message

test/github_pull_requests_presenter_test.rb

@@ -4,48 +4,49 @@ class TestGitHubPullRequestsPresenter < CC::Service::TestCase
   def test_message_no_issue_counts_in_payload
     assert_equal(
       "Code Climate has analyzed this pull request.",
-      message_from_payload({})
+      CC::Service::GitHubPullRequests::Presenter.new({}).success_message
     )
   end
 
   def test_message_singular
     assert_equal(
       "Code Climate found 1 new issue and 1 fixed issue.",
-      message_from_payload("fixed_issue_count" => 1, "new_issue_count" => 1)
+      message_from_issue_counts("fixed" => 1, "new" => 1)
     )
   end
 
   def test_message_plural
     assert_equal(
       "Code Climate found 2 new issues and 1 fixed issue.",
-      message_from_payload("fixed_issue_count" => 1, "new_issue_count" => 2)
+      message_from_issue_counts("fixed" => 1, "new" => 2)
     )
   end
 
   def test_message_only_fixed
     assert_equal(
       "Code Climate found 1 fixed issue.",
-      message_from_payload("fixed_issue_count" => 1, "new_issue_count" => 0)
+      message_from_issue_counts("fixed" => 1, "new" => 0)
     )
   end
 
   def test_message_only_new
     assert_equal(
       "Code Climate found 3 new issues.",
-      message_from_payload("fixed_issue_count" => 0, "new_issue_count" => 3)
+      message_from_issue_counts("fixed" => 0, "new" => 3)
     )
   end
 
   def test_message_no_new_or_fixed
     assert_equal(
       "Code Climate didn't find any new or fixed issues.",
-      message_from_payload("fixed_issue_count" => 0, "new_issue_count" => 0)
+      message_from_issue_counts("fixed" => 0, "new" => 0)
     )
   end
 
 private
 
-  def message_from_payload(payload)
+  def message_from_issue_counts(issue_counts)
+    payload = { "issue_comparison_counts" => issue_counts }
     CC::Service::GitHubPullRequests::Presenter.new(payload).success_message
   end
 end

test/github_pull_requests_test.rb

@@ -24,8 +24,10 @@ def test_pull_request_status_success_detailed
       github_slug: "pbrisbin/foo",
       commit_sha:  "abc123",
       state:       "success",
-      new_issue_count: 1,
-      fixed_issue_count: 2,
+      issue_comparison_counts: {
+        "fixed" => 2,
+        "new"   => 1,
+      }
     })
   end