Add test for the snapshot formatters.

Author: calavera

Rakefile

@@ -3,7 +3,8 @@ require 'rake/testtask'
 
 Rake::TestTask.new do |t|
   t.libs.push "lib"
-  t.test_files = FileList['test/*_test.rb']
+  t.libs.push "test"
+  t.test_files = FileList['test/**/*_test.rb']
   t.verbose = true
 end
 

lib/cc/formatters/snapshot_formatter.rb

@@ -44,17 +44,17 @@ class Base
       def initialize(repo, payload)
         @repo    = repo
 
-        new_constants = Array(payload["new_constants"])
-        changed_constants = Array(payload["changed_constants"])
+        new_constants = Array(payload[:new_constants])
+        changed_constants = Array(payload[:changed_constants])
 
-        alert_constants = new_constants.select(new_constants_selector)
-        alert_constants += changed_constants.select(decreased_constants_selector)
+        alert_constants = new_constants.select(&new_constants_selector)
+        alert_constants += changed_constants.select(&decreased_constants_selector)
 
-        improved_constants = changed_constants.select(improved_constants_selector)
+        improved_constants = changed_constants.select(&improved_constants_selector)
 
         data = {
-          from: { commit_sha: payload["previous_commit_sha"] },
-          to:   { commit_sha: payload["commit_sha"] }
+          from: { commit_sha: payload[:previous_commit_sha] },
+          to:   { commit_sha: payload[:commit_sha] }
         }
 
         @alert_constants_payload    = data.merge(constants: alert_constants) if alert_constants.any?
@@ -80,11 +80,11 @@ def repo_identifier
       end
 
       def to_rating(constant)
-        Rating.new(constant["to"]["rating"])
+        Rating.new(constant[:to][:rating])
       end
 
       def from_rating(constant)
-        Rating.new(constant["from"]["rating"])
+        Rating.new(constant[:from][:rating])
       end
     end
 

lib/cc/services/slack.rb

@@ -16,7 +16,7 @@ def receive_test
     speak(formatter.format_test)
 
     # payloads for test receivers include the weekly quality report.
-    send_snapshot_to_slack(CC::Formatters::SnapshotFormatter::Test.new(repo, payload))
+    send_snapshot_to_slack(CC::Formatters::SnapshotFormatter::Sample.new(repo, payload))
 
     { ok: true, message: "Test message sent" }
   rescue => ex

test/formatters/snapshot_formatter_test.rb

@@ -0,0 +1,47 @@
+require "helper"
+
+class TestSnapshotFormatter < Test::Unit::TestCase
+  def described_class
+    CC::Formatters::SnapshotFormatter::Base
+  end
+
+  def test_quality_alert_with_new_constants
+    f = described_class.new(nil, {new_constants: [{to: {rating: "D"}}], changed_constants: []})
+    refute_nil f.alert_constants_payload
+  end
+
+  def test_quality_alert_with_decreased_constants
+    f = described_class.new(nil, {new_constants: [],
+                                  changed_constants: [{to: {rating: "D"}, from: {rating: "A"}}]
+    })
+    refute_nil f.alert_constants_payload
+  end
+
+  def test_quality_improvements_with_better_ratings
+    f = described_class.new(nil, {new_constants: [],
+                                  changed_constants: [{to: {rating: "A"}, from: {rating: "D"}}]
+    })
+    refute_nil f.improved_constants_payload
+  end
+
+  def test_nothing_set_without_changes
+    f = described_class.new(nil, {new_constants: [], changed_constants: []})
+    assert_nil f.alert_constants_payload
+    assert_nil f.improved_constants_payload
+  end
+
+  def test_snapshot_formatter_test_with_relaxed_constraints
+    f = CC::Formatters::SnapshotFormatter::Sample.new(nil, {
+       new_constants: [{name: "foo", to: {rating: "A"}}, {name: "bar", to: {rating: "A"}}],
+       changed_constants: [
+         {from: {rating: "B"}, to: {rating: "C"}},
+         {from: {rating: "D"}, to: {rating: "D"}},
+         {from: {rating: "D"}, to: {rating: "D"}},
+         {from: {rating: "A"}, to: {rating: "B"}},
+         {from: {rating: "C"}, to: {rating: "B"}}
+       ]})
+
+    refute_nil f.alert_constants_payload
+    refute_nil f.improved_constants_payload
+  end
+end