Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 5e480b3

Browse files
committed
use return value of GithubPullRequest#update_status in update_state_success
Changing the order of these parameters so that the return value of `#update_status` is used instead of `#add_comment`. This hack corrects a bug in which the comment's return value is returned instead of the status. Of course the opposite bug still persists (the status's return value can now step on the return value of the comment). However, we are removing the commenting feature in the future, and update_status is already the default behavior for new GitHub repos. A better compromise might be to merge the resulting hashes?
1 parent 62f7517 commit 5e480b3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/cc/services/github_pull_requests.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ def update_status_skipped
6969
end
7070

7171
def update_status_success
72-
update_status("success", "Code Climate has analyzed this pull request.")
7372
add_comment
73+
update_status("success", "Code Climate has analyzed this pull request.")
7474
end
7575

7676
def update_status_error

0 commit comments

Comments
 (0)