Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 65df934

Browse files
committed
Remove rollout call for quality stats
1 parent 423b4ea commit 65df934

File tree

3 files changed

+19
-15
lines changed

3 files changed

+19
-15
lines changed

lib/cc/presenters/github_pull_requests_presenter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def initialize(payload, repo_config)
1313
end
1414

1515
def success_message
16-
if @repo_config.pr_status_quality_stats?
16+
if issue_counts_in_payload?
1717
if both_issue_counts_zero?
1818
"Code Climate didn't find any new or fixed issues."
1919
else

test/github_pull_requests_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,10 @@ def test_pull_request_comment
179179
number: 1,
180180
state: "success",
181181
compare_url: "http://example.com",
182+
issue_comparison_counts: {
183+
"fixed" => 2,
184+
"new" => 1,
185+
}
182186
})
183187
end
184188

test/presenters/github_pull_requests_presenter_test.rb

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,45 +2,45 @@
22
require "cc/presenters/github_pull_requests_presenter"
33

44
class TestGitHubPullRequestsPresenter < CC::Service::TestCase
5-
def test_message_quality_stats_not_enabled
6-
assert_equal(
7-
"Code Climate has analyzed this pull request.",
8-
build_presenter(false, "fixed" => 1, "new" => 1).success_message
9-
)
10-
end
11-
125
def test_message_singular
136
assert_equal(
147
"Code Climate found 1 new issue and 1 fixed issue.",
15-
build_presenter(true, "fixed" => 1, "new" => 1).success_message
8+
build_presenter("fixed" => 1, "new" => 1).success_message
169
)
1710
end
1811

1912
def test_message_plural
2013
assert_equal(
2114
"Code Climate found 2 new issues and 1 fixed issue.",
22-
build_presenter(true, "fixed" => 1, "new" => 2).success_message
15+
build_presenter("fixed" => 1, "new" => 2).success_message
2316
)
2417
end
2518

2619
def test_message_only_fixed
2720
assert_equal(
2821
"Code Climate found 1 fixed issue.",
29-
build_presenter(true, "fixed" => 1, "new" => 0).success_message
22+
build_presenter("fixed" => 1, "new" => 0).success_message
3023
)
3124
end
3225

3326
def test_message_only_new
3427
assert_equal(
3528
"Code Climate found 3 new issues.",
36-
build_presenter(true, "fixed" => 0, "new" => 3).success_message
29+
build_presenter("fixed" => 0, "new" => 3).success_message
3730
)
3831
end
3932

4033
def test_message_no_new_or_fixed
4134
assert_equal(
4235
"Code Climate didn't find any new or fixed issues.",
43-
build_presenter(true, "fixed" => 0, "new" => 0).success_message
36+
build_presenter("fixed" => 0, "new" => 0).success_message
37+
)
38+
end
39+
40+
def test_message_no_issue_counts
41+
assert_equal(
42+
"Code Climate has analyzed this pull request.",
43+
build_presenter({}).success_message
4444
)
4545
end
4646

@@ -50,10 +50,10 @@ def build_payload(issue_counts)
5050
{ "issue_comparison_counts" => issue_counts }
5151
end
5252

53-
def build_presenter(quality_stats_enabled, issue_counts)
53+
def build_presenter(issue_counts)
5454
CC::Service::GitHubPullRequestsPresenter.new(
5555
build_payload(issue_counts),
56-
OpenStruct.new(pr_status_quality_stats?: quality_stats_enabled)
56+
OpenStruct.new
5757
)
5858
end
5959
end

0 commit comments

Comments
 (0)