Give a not-ok result if there is no handler

Author: Jon Yurek

lib/cc/service.rb

@@ -87,7 +87,7 @@ def receive
         end
       end
 
-      nil
+      { ok: false, message: "No service handler found" }
     end
 
     private

lib/cc/services/github_pull_requests.rb

@@ -34,7 +34,7 @@ def receive_test
     elsif config.add_comment
       receive_test_comment
     else
-      { ok: true, message: "Nothing happened" }
+      simple_failure("Nothing happened")
     end
   end
 
@@ -43,21 +43,47 @@ def receive_pull_request
 
     case @payload["state"]
     when "pending"
-      update_status("pending", "Code Climate is analyzing this code.")
+      update_status_pending
     when "success"
-      add_comment
-      update_status("success", "Code Climate has analyzed this pull request.")
+      if config.update_status && config.add_comment
+        update_status_success
+        add_comment
+      elsif config.update_status
+        update_status_success
+      elsif config.add_comment
+        add_comment
+      else
+        simple_failure("Nothing happened")
+      end
     when "error"
-      update_status(
-        "error",
-        "Code Climate encountered an error while attempting to analyze this " +
-          "pull request."
-      )
+      update_status_error
+    else
+      simple_failure("Unknown state")
     end
   end
 
 private
 
+  def simple_failure(message)
+    { ok: false, message: message }
+  end
+
+  def update_status_success
+    update_status("success", "Code Climate has analyzed this pull request.")
+  end
+
+  def update_status_error
+    update_status(
+      "error",
+      "Code Climate encountered an error while attempting to analyze this " +
+      "pull request."
+    )
+  end
+
+  def update_status_pending
+    update_status("pending", "Code Climate is analyzing this code.")
+  end
+
   def update_status(state, description)
     if config.update_status
       params = {

test/service_test.rb

@@ -21,6 +21,15 @@ def test_custom_path_to_ca_file
     ENV.delete("CODECLIMATE_CA_FILE")
   end
 
+  def test_nothing_has_a_handler
+    service = CC::Service.new({}, {name: "test"})
+
+    result = service.receive
+
+    assert_equal false, result[:ok]
+    assert_equal "No service handler found", result[:message]
+  end
+
   def test_post_success
     stub_http("/my/test/url", [200, {}, '{"ok": true, "thing": "123"}'])