Fix load-order dependency

This fixes an `unitialized constant CC::Service::GitHubPullRequests`,
which was happening if `CC::Service::GithubPullRequests::Presenter` was loaded
before `CC::Service::GithubPullRequests`. Loading order is non-deterministic and
can differ depending on OS, since services are loaded via `Dir[]`).

Going forward, services that need a presenter class can require the presenter
themselves.

Author: Ian C. Anderson

lib/cc/presenters/github_pull_requests_presenter.rb

@@ -0,0 +1,62 @@
+module CC
+  class Service
+    class GitHubPullRequestsPresenter
+      def initialize(payload, repo_config)
+        issue_comparison_counts = payload["issue_comparison_counts"]
+
+        if issue_comparison_counts
+          @fixed_count = issue_comparison_counts["fixed"]
+          @new_count = issue_comparison_counts["new"]
+        end
+
+        @repo_config = repo_config
+      end
+
+      def success_message
+        if @repo_config.pr_status_quality_stats?
+          if both_issue_counts_zero?
+            "Code Climate didn't find any new or fixed issues."
+          else
+            "Code Climate found #{formatted_issue_counts}."
+          end
+        else
+          "Code Climate has analyzed this pull request."
+        end
+      end
+
+    private
+
+      def both_issue_counts_zero?
+        issue_counts.all?(&:zero?)
+      end
+
+      def formatted_fixed_issues
+        if @fixed_count > 0
+          "#{@fixed_count} fixed #{"issue".pluralize(@fixed_count)}"
+        else
+          nil
+        end
+      end
+
+      def formatted_new_issues
+        if @new_count > 0
+          "#{@new_count} new #{"issue".pluralize(@new_count)}"
+        else
+          nil
+        end
+      end
+
+      def formatted_issue_counts
+        [formatted_new_issues, formatted_fixed_issues].compact.to_sentence
+      end
+
+      def issue_counts
+        [@new_count, @fixed_count]
+      end
+
+      def issue_counts_in_payload?
+        issue_counts.all?
+      end
+    end
+  end
+end

lib/cc/services/github_pull_requests.rb

@@ -1,3 +1,5 @@
+require "cc/presenters/github_pull_requests_presenter"
+
 class CC::Service::GitHubPullRequests < CC::Service
   class Config < CC::Service::Config
     attribute :oauth_token, String,
@@ -74,7 +76,7 @@ def update_status_success
   end
 
   def presenter
-    CC::Service::GitHubPullRequests::Presenter.new(@payload, @repo_config)
+    CC::Service::GitHubPullRequestsPresenter.new(@payload, @repo_config)
   end
 
   def update_status_error

lib/cc/services/github_pull_requests_presenter.rb

@@ -1,4 +1,5 @@
-require File.expand_path('../helper', __FILE__)
+require "helper"
+require "cc/presenters/github_pull_requests_presenter"
 
 class TestGitHubPullRequestsPresenter < CC::Service::TestCase
   def test_message_quality_stats_not_enabled
@@ -50,7 +51,7 @@ def build_payload(issue_counts)
   end
 
   def build_presenter(quality_stats_enabled, issue_counts)
-    CC::Service::GitHubPullRequests::Presenter.new(
+    CC::Service::GitHubPullRequestsPresenter.new(
       build_payload(issue_counts),
       OpenStruct.new(pr_status_quality_stats?: quality_stats_enabled)
     )