Merge pull request #60 from codeclimate/pull_requests_return_true_if_comment_present

marshally · marshally · commit 97895978b70a · 2015-03-20T12:45:44.000-05:00
return true when pull request commenting is enabled and a comment exists
diff --git a/lib/cc/services/github_pull_requests.rb b/lib/cc/services/github_pull_requests.rb
@@ -110,7 +110,7 @@ def add_comment
         end
       else
         @response = {
-          ok: false,
+          ok: true,
           message: "Comment already present"
         }
       end
diff --git a/test/github_pull_requests_test.rb b/test/github_pull_requests_test.rb
@@ -177,7 +177,7 @@ def test_pull_request_comment_already_present
       state:       "success",
     })
 
-    assert_equal({ ok: false, message: "Comment already present" }, response)
+    assert_equal({ ok: true, message: "Comment already present" }, response)
   end
 
   def test_pull_request_unknown_state

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ def add_comment`
`110`	`110`	`end`
`111`	`111`	`else`
`112`	`112`	`@response = {`
`113`		`- ok: false,`
	`113`	`+ ok: true,`
`114`	`114`	`message: "Comment already present"`
`115`	`115`	`}`
`116`	`116`	`end`