Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 9ec9161

Browse files
author
ABaldwinHunter
committed
update tests
1 parent 67271c5 commit 9ec9161

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

test/github_pull_requests_test.rb

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,28 @@ def test_pull_request_status_success_generic
6262
def test_pull_request_status_error
6363
expect_status_update("pbrisbin/foo", "abc123", {
6464
"state" => "error",
65-
"description" => /encountered an error/,
65+
"description" => CC::Service::GitHubPullRequests::DEFAULT_ERROR,
6666
})
6767

6868
receive_pull_request({ update_status: true }, {
6969
github_slug: "pbrisbin/foo",
7070
commit_sha: "abc123",
7171
state: "error",
72-
message: "Code Climate encountered an error while attempting to analyze this pull request.",
72+
message: nil,
73+
})
74+
end
75+
76+
def test_pull_request_status_error_message_provided
77+
expect_status_update("pbrisbin/foo", "abc123", {
78+
"state" => "error",
79+
"description" => "descriptive message",
80+
})
81+
82+
receive_pull_request({ update_status: true }, {
83+
github_slug: "pbrisbin/foo",
84+
commit_sha: "abc123",
85+
state: "error",
86+
message: "descriptive message",
7387
})
7488
end
7589

@@ -113,7 +127,7 @@ def test_no_status_update_for_error_when_update_status_config_is_falsey
113127
github_slug: "pbrisbin/foo",
114128
commit_sha: "abc123",
115129
state: "error",
116-
message: "Code Climate encountered an error while attempting to analyze this pull request.",
130+
message: nil,
117131
})
118132
end
119133

0 commit comments

Comments
 (0)