Do not use #to_json on HipChat's params

Author: Jon Yurek

lib/cc/services/hipchat.rb

@@ -51,7 +51,7 @@ def speak(message, color)
       notify:     !!config.notify,
       color:      color
     }
-    post(url, params.to_json)
+    post(url, params)
   end
 
 end

test/flowdock_test.rb

@@ -3,8 +3,8 @@
 class TestFlowdock < CC::Service::TestCase
   def test_valid_project_parameter
     @stubs.post '/v1/messages/team_inbox/token' do |env|
-      body = env[:body]
-      assert_equal "Exampleorg", body[:project]
+      body = Hash[URI.decode_www_form(env[:body])]
+      assert_equal "Exampleorg", body["project"]
       [200, {}, '']
     end
 
@@ -127,15 +127,15 @@ def token
 
   def assert_flowdock_receives(subject, event_data, expected_body)
     @stubs.post request_url do |env|
-      body = env[:body]
-      assert_equal "Code Climate", body[:source]
-      assert_equal "[email protected]", body[:from_address]
-      assert_equal "Code Climate", body[:from_name]
-      assert_equal "html", body[:format]
-      assert_equal subject, body[:subject]
-      assert_equal "Example", body[:project]
-      assert_equal expected_body, body[:content]
-      assert_equal "https://codeclimate.com", body[:link]
+      body = Hash[URI.decode_www_form(env[:body])]
+      assert_equal "Code Climate", body["source"]
+      assert_equal "[email protected]", body["from_address"]
+      assert_equal "Code Climate", body["from_name"]
+      assert_equal "html", body["format"]
+      assert_equal subject, body["subject"]
+      assert_equal "Example", body["project"]
+      assert_equal expected_body, body["content"]
+      assert_equal "https://codeclimate.com", body["link"]
       [200, {}, '']
     end
 

test/hipchat_test.rb

@@ -108,10 +108,10 @@ def test_receive_test
 
   def assert_hipchat_receives(color, event_data, expected_body)
     @stubs.post '/v1/rooms/message' do |env|
-      body = JSON.parse(env[:body])
+      body = Hash[URI.decode_www_form(env[:body])]
       assert_equal "token", body["auth_token"]
       assert_equal "123", body["room_id"]
-      assert_equal true, body["notify"]
+      assert_equal "true", body["notify"]
       assert_equal color, body["color"]
       assert_equal expected_body, body["message"]
       [200, {}, '']